WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#36407 closed defect (bug) (fixed)

Coding typo: space should be after closing quote, not before

Reported by: dimadin's profile dimadin Owned by: ocean90's profile ocean90
Milestone: 4.5 Priority: lowest
Severity: trivial Version: 4.1
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description

While translating, I've noticed this. Since administration should already get new strings for "About" screen, this can go for 4.5.

Attachments (1)

36407.patch​ (1.9 KB) - added by dimadin 8 years ago.

Download all attachments as: .zip

Change History (11)

@dimadin
8 years ago

#1 @ocean90
8 years ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 4.5
  • Priority changed from normal to lowest
  • Severity changed from normal to trivial
  • Version changed from trunk to 4.1

Introduced in [30705], changed in [36971].

#2 @kirasong
8 years ago

  • Owner set to @…
  • Status changed from new to assigned

#3 @kirasong
8 years ago

  • Owner changed from @… to ocean90

#4 @DrewAPicture
8 years ago

36407.patch​ looks good to me.

This ticket was mentioned in ​Slack in #core by mike. ​View the logs.
8 years ago

#6 @pento
8 years ago

  • Keywords 2nd-opinion added; commit removed

@ocean90, @petya: Could you please confirm that you're okay with the string change this close to release? If so, this patch is fine to commit.

#7 @petya
8 years ago

We have not announced a string freeze and the global outreach for GTEs will go out tomorrow. I think it's ok. Still needs @ocean90 to confirm in case I'm missing something.

#8 @ocean90
8 years ago

I gave my OK in comment:1 with the 'commit' keyword already.

#9 @ocean90
8 years ago

  • Keywords commit added; 2nd-opinion removed

#10 @ocean90
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 37159:

Editor: Remove trailing space from a help text string.

Props dimadin.
Fixes #36407.

Note: See TracTickets for help on using tickets.