WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#36427 closed enhancement (fixed)

Edit_Comment Should Pass CommentData

Reported by: dshanske Owned by: dshanske
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: Comments Keywords: needs-patch needs-refresh
Focuses: Cc:

Description

Action 'edit_comment', which fires on comment update, should pass $commentdata along to it.

For one, 'comment_post' now does this. This would allow an action to perform additional work...such as in the comment meta, passed by whatever triggered the update function.

Attachments (3)

36427.diff (682 bytes) - added by dshanske 3 years ago.
36427.2.diff (705 bytes) - added by dshanske 3 years ago.
Fix Document
36427.3.diff (762 bytes) - added by rachelbaker 3 years ago.
Minor docs formatting fixes

Download all attachments as: .zip

Change History (9)

#1 @rachelbaker
3 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

@dshanske sounds reasonable. Want to create a patch for 4.6?

@dshanske
3 years ago

This ticket was mentioned in Slack in #core-comments by dshanske. View the logs.


3 years ago

This ticket was mentioned in Slack in #core-comments by dshanske. View the logs.


3 years ago

#4 @rachelbaker
3 years ago

  • Keywords needs-refresh added
  • Milestone changed from Future Release to 4.6
  • Owner set to dshanske
  • Status changed from new to assigned

36427.diff makes sense, but the inline docs need a refresh to match the standards.

Assigned to @dshanske to refresh based on https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#since-section-changelogs.

Last edited 3 years ago by rachelbaker (previous) (diff)

@dshanske
3 years ago

Fix Document

#5 @dshanske
3 years ago

@rachelbaker Think that should fix it.

@rachelbaker
3 years ago

Minor docs formatting fixes

#6 @rachelbaker
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 37423:

Comments: Add $data parameter to include the comment data in the edit_comment action.

Props dshanske.

Fixes #36427.

Note: See TracTickets for help on using tickets.