Twenty Eleven Ephemera widget fails to prevent caching in Customizer preview

[westonruter]

Changes to Twenty Eleven's Ephemera widget are currently getting cached when being changes in the Customizer Preview. This is specifically a problem when an external persistent object cache is used, since the cache gets dumped with each request otherwise.

A change somewhat like this is needed:

src/wp-content/themes/twentyeleven/inc/widgets.php

@@ -56 +56 @@
                 if ( ! isset( $args['widget_id'] ) )
                         $args['widget_id'] = null;
 
-                if ( isset( $cache[ $args['widget_id'] ] ) ) {
+                if ( ! is_customize_preview() && isset( $cache[ $args['widget_id'] ] ) ) {
                         echo $cache[ $args['widget_id'] ];
                         return;
                 }
@@ -132 +132 @@
                 endif;
 
                 $cache[ $args['widget_id'] ] = ob_get_flush();
-                wp_cache_set( 'widget_twentyeleven_ephemera', $cache, 'widget' );
+                if ( ! is_customize_preview() ) {
+                        wp_cache_set( 'widget_twentyeleven_ephemera', $cache, 'widget' );
+                }
         }
 
         /**

[anneschmidt]

added is_customize_preview()

[anneschmidt]

New contributor here, so hopefully I'm doing this right.

I was able to duplicate this issue in the twentyeleven theme by installing W3 Total Cache and toggling on all caching types. After activating the cache, I went to edit the title of the Ephemera widget in the Customizer. The new title did not show up in the preview pane.

After the changes to widgets.php, I went back into the Customizer and was able to edit and view the new title.

[karmatosed]

Hi @anneschmidt and welcome. Unfortunately, I am unable to get your patch working. Can you please follow the instructions here for creating a patch: ​https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/. I do notice also, you have a few new lines that @westonruter's suggestion doesn't. It would be a good idea to tidy those.

If you are having issues creating the patch, just let us know and I can commit your suggestion still in your name. Thanks so much for contributing.

[anneschmidt]

Hi @karmatosed - thanks so much for your feedback and help. I'm attaching a second patch - can you let me know if this one works for you? Thanks!

[karmatosed]

In 37590:

Twenty Elevent Ephemera widget fix for caching in Customizer preview.
Fixes #36429. Props anneschmidt, westonruter.

[karmatosed]

@anneschmidt just to let you know, I couldn't get your patch working. However, I took the work you'd done and made a fix for that. Thanks for sending your patch in and if this is your first props - congratulations!