Explicitly cast numeric values

[pento]

PHP 7.1 will include warnings when invalid values are being used in numeric operations, per ​this RFC.

This is currently manifesting itself as a ​single unit test error against PHP Nightly, but it's likely that there are more places we'll see this warning, which aren't being covered by unit tests.

I'm not aware of any static analysis tools that are covering this case yet, but in the mean time, we could potentially look for problem code with some simple searching.

[dd32]

Milestoning this as it's something we should really start looking into before the PHP 7.1 release, at least to know where/what will be affected.

[pento]

src$ ack --php --ignore-dir=ID3 --ignore-dir=wp-content/plugins --ignore-dir=SimplePie --ignore-dir=Requests '^\s*((?!//|\*).)*(\+\+|--)?\$[^ (),'\''";]+((\+\+|--[^>])| ([+*-]|/[^>]))' | wc -l
794

[pento]

In 37549:

Embeds: Ensure embed widths are integers.

This prevents a warning in PHP trunk when a non-integer width is passed.

See #36435.

[lukecavanagh]

Patch for class-wp-comments-list-table.php

[lukecavanagh]

Not sure if this was the direction you where thinking.

[pento]

That's the general idea. We should also be adding unit tests as we go.

PHP 7.1 is ​scheduled for release in November or maybe December, so we're going to need to make a serious dent in this task in 4.6.

[pento]

Scrutinizer are ​investigating adding a check for this.

[joostdevalk]

Patch for compat/random.php

[joostdevalk]

Added a patch, let me know if i got it right and I'll happily go over a few more files.

[SergeyBiryukov]

Replying to joostdevalk:

Added a patch, let me know if i got it right and I'll happily go over a few more files.

Seems good, however ​random_compat is an external library, so the fix should probably be submitted upstream.

[joostdevalk]

Replying to SergeyBiryukov:

Replying to joostdevalk:

Added a patch, let me know if i got it right and I'll happily go over a few more files.

Seems good, however ​random_compat is an external library, so the fix should probably be submitted upstream.

You're right. ​done.

[joostdevalk]

The patch was accepted upstream, but of course there's no new release of it yet. What's the best way to go about that @SergeyBiryukov ?

[ocean90]

PclZip can produce a warning when it's used:

Notice: A non well formed numeric value encountered in /wp-admin/includes/class-pclzip.php on line 1849

Patched in 36435-PclZip.2.diff​.

[ocean90]

In 38101:

Filesystem API: Ensure memory limit calculations by PclZip are using integers.

This prevents a warning in PHP trunk, see ​https://wiki.php.net/rfc/invalid_strings_in_arithmetic.

See #36435.

[ocean90]

I'm using ​a fork of VVV which installs PHP 7.1 and haven't noticed any more warnings so far.

[pento]

I'm closing this for now, as we don't have a good way of detecting warnings. We can fix it piecemeal as bugs are found, or this ticket can be re-opened if a static analyser adds checking.