customize_value should be passed $this

[nwp_developer]

In $WP_Customize_Setting->value():

$value = apply_filters( "customize_value_{$id_base}", $value );

should be

$value = apply_filters( "customize_value_{$id_base}", $this);

because only having access to $default severely limits the ability to modify the value for custom settings not handled as theme_mod or option.

For example, if I need access to other setting properties at add_filter(customize_value...) to filter the setting value how do I get access to those properties?

[celloexpressions]

Pass $this to the customize_value_ filter.

[westonruter]

You are absolutely right. See #29316 and review patch. I the mean time, I recommend using a WP_Customize_Setting subclass in lieu of using hooks to handle your custom setting type.

[celloexpressions]

Good catch @nwp_developer!

I think this was an oversight when we started passing $this with all of the hooks here (hence marking as a bug). Every action and filter in WP_Customize_Setting passes $this as its last argument with this change; see 36452.diff​. We do need to keep $value as the first argument for backwards compatibility, so a second parameter with the setting would be passed as well now. See previously #27979.

Per Slack discussion, let's see if we can get this smaller change in without waiting for a full resolution of the proposed new hooks in #29316.

[celloexpressions]

Slackbot missed the ticket: ​https://wordpress.slack.com/archives/core-customize/p1460145042000403

[celloexpressions]

36452.diff​ should be ready for commit.

[nwp_developer]

Thanks!

Can anyone give me a start to how to use do_action( "customize_preview_{$this->type}", $this ) if I have a setting that's saved outside of wp_options?

How would I handle the customizer iframe preview similar to how get_theme_mod() works? I can't use transport=>postMessage since content is dynamic.

[westonruter]

Replying to nwp_developer:

Can anyone give me a start to how to use do_action( "customize_preview_{$this->type}", $this ) if I have a setting that's saved outside of wp_options?

How would I handle the customizer iframe preview similar to how get_theme_mod() works? I can't use transport=>postMessage since content is dynamic.

Please ask this question on the ​support forums or on the ​WordPress Dev Stack Exchange.

[westonruter]

Add unit tests

[westonruter]

In 37350:

Customize: Pass WP_Customize_Setting instance as second argument to customize_value_{$id_base} filter.

Adds parity with setting instance being passed as second argument to customize_sanitize_{$id} and customize_sanitize_js_{$id}. Allows the actual ID of the (multidimensional) setting value being filtered to be inspected.

Props celloexpressions, westonruter.
Fixes #36452.