Disable 'replace' button in replace media frame while attachment is uploading

[ungestaltbar]

Steps to reproduce:

1. Edit a post
2. Insert an image into the editor
3. Click on the image and chose 'edit' (pen icon)
4. Chose 'replace' in the dialog
5. Upload a new image.
6. Click on the 'replace' button while the image is still uploading

Console throws javascript error.

(possible) Solution:

Add the require option to the toolbar.items.replace button config,
around line 5082 in media-views.js

replace: {
	style:    'primary',
	text:     l10n.replace,
	priority: 80,
        requires: { selection: true },
        ....

Tested version: Version 4.5-RC1-37153

[shahpranaf]

Hi @ungestaltbar's,

Firstly thanks for posting this bug. I followed the steps and confirm that its a bug.
And yes you were right about missing require selection option. I have fixed that bug with the patch.

Thanks

[jeremyfelt]

Confirmed as well. For posterity, the error:

Uncaught TypeError: Cannot read property 'medium' of undefined in media-models.js?ver=4.5-RC2-37173-src:1072

This likely goes back to the introduction of replacing an image in the editor via [27050].

[shahpranaf]

Any feedback? IT would be great if we can incorporate in 4.6

[wonderboymusic]

Duplicate of #40589.

Fixed in [40902]