#36458 closed defect (bug) (fixed)
Fix support for Safari + VoiceOver when editing inline links
Reported by: | jeremyfelt | Owned by: | afercia |
---|---|---|---|
Milestone: | 4.5.1 | Priority: | normal |
Severity: | normal | Version: | 4.5 |
Component: | Editor | Keywords: | has-patch fixed-major |
Focuses: | accessibility | Cc: |
Description
From @afercia's comment on #33301:
About the issue with Safari, I've recently had the opportunity to test using Safari+VoiceOver and noticed the Twitter search suggestion (which perfectly works) sets an aria-selected="true" on the highlighted option item. Quickly tried that and it seems it makes Safari understand what's going on, finally the autocomplete items get read out. Need to build a clean patch and test a lot but we're probably on the right track now :)
Can confirm that in Safari after Cmd+K the focus goes forth and back from the Editor to the combobox 2-3 times, sometimes it lands on the search field, sometimes not. Couldn't reproduce consistently.
Please consider I'm a newbie with VoiceOver, but I've noticed this focus "jump" doesn't happen when I diligently follow VoiceOver instructions telling me: "To enter the web area, press Control-Option-Shift-Down Arrow". After this, everything works nicely. Would greatly appreciate some feedback from VoiceOver experienced users, specifically if pressing "Control-Option-Shift-Down Arrow" enters a sort of "forms mode" and affects how JavaScript keyboard events behave. @MarcoZ any thoughts? When you have a chance! Thanks very much :)
I'm attaching @afercia's patch to fix this issue as well.
Attachments (1)
Change History (11)
This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.
9 years ago
#2
@
9 years ago
- Keywords needs-testing removed
- Milestone changed from Future Release to 4.5.1
- Owner set to afercia
- Status changed from new to assigned
@rianrietveld tested the patch with VoiceOver, confirmed it works nicely see
https://wordpress.slack.com/archives/accessibility/p1460401740000720
Worth noting the aria-selected
attribute is also used in other "big" implementations, e.g. Twitter. I'd propose to consider this for 4.5.1. Also, anyone who can test on a Mac using Safari and VoiceOver is very welcome.
#3
@
9 years ago
I think it makes sense to include this in 4.5.1. Will test the patch on Safari as well, but any more tests from other people are highly appreciated of course.
#7
@
9 years ago
- Keywords fixed-major added; commit removed
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for 4.5.1
@afercia's patch from #33301