Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#36458 closed defect (bug) (fixed)

Fix support for Safari + VoiceOver when editing inline links

Reported by: jeremyfelt Owned by: afercia
Milestone: 4.5.1 Priority: normal
Severity: normal Version: 4.5
Component: Editor Keywords: has-patch fixed-major
Focuses: accessibility Cc:


From @afercia's comment on #33301:

About the issue with Safari, I've recently had the opportunity to test using Safari+VoiceOver and noticed the Twitter search suggestion (which perfectly works) sets an aria-selected="true" on the highlighted option item. Quickly tried that and it seems it makes Safari understand what's going on, finally the autocomplete items get read out. Need to build a clean patch and test a lot but we're probably on the right track now :)
Can confirm that in Safari after Cmd+K the focus goes forth and back from the Editor to the combobox 2-3 times, sometimes it lands on the search field, sometimes not. Couldn't reproduce consistently.
Please consider I'm a newbie with VoiceOver, but I've noticed this focus "jump" doesn't happen when I diligently follow VoiceOver instructions telling me: "To enter the web area, press Control-Option-Shift-Down Arrow". After this, everything works nicely. Would greatly appreciate some feedback from VoiceOver experienced users, specifically if pressing "Control-Option-Shift-Down Arrow" enters a sort of "forms mode" and affects how JavaScript keyboard events behave. @MarcoZ any thoughts? When you have a chance! Thanks very much :)

I'm attaching @afercia's patch to fix this issue as well.

Attachments (1)

33301.voiceover.diff (1.4 KB) - added by jeremyfelt 6 years ago.
@afercia's patch from #33301

Download all attachments as: .zip

Change History (11)

6 years ago

@afercia's patch from #33301

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.

6 years ago

#2 @afercia
6 years ago

  • Keywords needs-testing removed
  • Milestone changed from Future Release to 4.5.1
  • Owner set to afercia
  • Status changed from new to assigned

@rianrietveld tested the patch with VoiceOver, confirmed it works nicely see

Worth noting the aria-selected attribute is also used in other "big" implementations, e.g. Twitter. I'd propose to consider this for 4.5.1. Also, anyone who can test on a Mac using Safari and VoiceOver is very welcome.

Last edited 6 years ago by afercia (previous) (diff)

#3 @swissspidy
6 years ago

I think it makes sense to include this in 4.5.1. Will test the patch on Safari as well, but any more tests from other people are highly appreciated of course.

#4 @afercia
6 years ago

@swissspidy thanks :) Any Mac users, please press Cmd + F5 on your keyboard :)

#5 @swissspidy
6 years ago

  • Keywords commit added

Patch works great and is good to go in my opinion.

#6 @swissspidy
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 37228:

TinyMCE, inline link: Fix VoiceOver in Safari for search suggestions.

Props afercia.
Fixes #36458.

#7 @swissspidy
6 years ago

  • Keywords fixed-major added; commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 4.5.1

This ticket was mentioned in Slack in #core by swissspidy. View the logs.

6 years ago

#9 @ocean90
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 37246:

TinyMCE, inline link: Fix VoiceOver in Safari for search suggestions.

Merge of [37228] to the 4.5 branch.

Props afercia.
Fixes #36458.

#10 @swissspidy
6 years ago

  • Version set to 4.5
Note: See TracTickets for help on using tickets.