WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#36463 closed defect (bug) (invalid)

Horizontal Rule QUnit test fails from the command line

Reported by: adamsilverstein's profile adamsilverstein Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.6
Component: Editor Keywords: has-screenshots has-patch 2nd-opinion
Focuses: Cc:

Description

The added QUnit test tinymce.plugins.wptextpattern - Horizontal Rule for the edit <hr> shortcut (---) fails when run from the command line. The exception shows that the patter was not expanded.

Attachments (1)

36463.diff​ (672 bytes) - added by adamsilverstein 9 years ago.

Download all attachments as: .zip

Change History (4)

#1 @adamsilverstein
9 years ago

  • Keywords has-screenshots added

Screenshot showing the failing test:
http://cl.ly/0N302r2g2d1W/1._adamsilversteinAdams-MacBook-Pro-2_develop.svn.wordpress.orgtrunk_zsh_2016-04-10_08-08-12.jpg

@adamsilverstein
9 years ago

#2 @adamsilverstein
9 years ago

  • Keywords has-patch 2nd-opinion added

36463.diff​

  • Adjust the hr test to pass when run from the command line.
  • Match the pattern established in other tests: start with the shortcut text, type a return \n and test what happens.

#3 @adamsilverstein
9 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

May have been an out of date library; after some further testing and updating everything the original test passes as expected. Closing.

Note: See TracTickets for help on using tickets.