Add tests for sign on related functions

[slimndap]

I don't think that the login procedure and the underlying wp_signon() are covered by (php)unit tests.
Since this is something quite trivial, I believe this should be added.

I tried to add it myself, but failed. Keep running into Cannot modify header information - headers already sent errors.

[desrosj]

Hi @slimndap,

Welcome to Trac! My apologies this took so long to receive a response.

It's been a while so I took a look. Seems there is one test for wp_signon() now that was added while solving #38744, but this area could definitely benefit from more unit tests (wp_authenticate_username_password(), wp_authenticate_email_password(), and wp_authenticate_cookie()` also do not have any tests).

[johnregan3]

Test for wp_authenticate functions

[johnregan3]

Added tests for wp_authenticate_username_password(), wp_authenticate_email_password(), and wp_authenticate_cookie().

[JordanPak]

Unsets the AUTH_COOKIE and SECURE_AUTH_COOKIE so test_wp_authenticate_cookie_with_invalid_cookie() doesn't cause Tests_Auth::test_wp_signon_does_not_throw_deprecation_notices_with_default_parameters to fail

[JordanPak]

@johnregan3 the new Tests_Auth::test_wp_authenticate_cookie_with_invalid_cookie() appeared to be throwing off the existing Tests_Auth::test_wp_signon_does_not_throw_deprecation_notices_with_default_parameters test because the $_COOKIE values were carrying over. The test was succeeding by itself but failing when run with the other tests in Tests_Auth.

36476.2.diff is addressing the issue in my tests.

[jorbin]

Reviewing this now, the new tests are looking good. Going to commit it.

[jorbin]

In 56454:

Login and Registration: Improve test coverage for sign on related functions

Adds new tests to ensure that wp_authenticate_email_password, wp_authenticate_username_password, and wp_authenticate_cookie are better tested. This also unsets cookies properly between tests.

Props JordanPak, johnregan3.
Fixes #36476.