Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#36482 closed enhancement (fixed)

Improve editor scrolling

Reported by: iseulde's profile iseulde Owned by: iseulde's profile iseulde
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: Editor Keywords:
Focuses: Cc:

Description

Maybe we can look into keeping the main toolbar hidden when scrolling down, while showing it when scrolling up. This way we can also use CSS to make showing and hiding of it smoother, instead of JavaScript. This kind of experience is widely used now, so a lot of users would already be used to it.

Attachments (11)

36482.patch (3.8 KB) - added by iseulde 10 years ago.
36482.2.patch (4.8 KB) - added by iseulde 10 years ago.
36482.3.patch (4.5 KB) - added by iseulde 10 years ago.
36482.4.patch (4.7 KB) - added by iseulde 10 years ago.
36482.5.patch (1.3 KB) - added by iseulde 10 years ago.
36482.6.patch (1.8 KB) - added by iseulde 10 years ago.
36482.7.patch (1.8 KB) - added by iseulde 10 years ago.
36482.8.patch (1.6 KB) - added by iseulde 10 years ago.
36482.9.patch (1.6 KB) - added by azaozz 10 years ago.
36482.10.patch (1.8 KB) - added by azaozz 10 years ago.
36482.11.patch (1.7 KB) - added by azaozz 10 years ago.

Download all attachments as: .zip

Change History (23)

@iseulde
10 years ago

@iseulde
10 years ago

@iseulde
10 years ago

@iseulde
10 years ago

#1 @iseulde
10 years ago

In 37596:

Editor: better resizing for text editor

  • Use scrollHeight to resize the text editor.
  • Don't scroll the cursor into view when under the text editor's toolbar, it involves cloning the content which is quite slow.

Props iseulde, azaozz.

See #36482.

@iseulde
10 years ago

@iseulde
10 years ago

#2 @iseulde
10 years ago

  • Milestone changed from Awaiting Review to 4.6

In 36482.6.patch:

  • Fix reducing.
  • Don't reduce more than the minimum height.
  • Scroll up the difference so that the cursor does not disappear under the toolbar when using BACKSPACE.

#3 @iseulde
10 years ago

  • Owner set to iseulde
  • Status changed from new to accepted

@iseulde
10 years ago

@iseulde
10 years ago

@azaozz
10 years ago

@azaozz
10 years ago

#4 @azaozz
10 years ago

In 36482.10.patch:

  • Don't adjust the Text editor height to smaller than autoresizeMinHeight.
  • Fix the adjustment on backspace.

@azaozz
10 years ago

#5 @azaozz
10 years ago

In 36482.11.patch: when shrinking the textarea, run adjust() only if it was actually resized.

#6 @iseulde
10 years ago

In 37603:

Editor: autoresize fixes for text

  • Resize on backspace.
  • Don't make it smaller than the minimum height.

Props azaozz, iseulde.

See #36482.

This ticket was mentioned in Slack in #core by ocean90. View the logs.


10 years ago

#8 @ocean90
10 years ago

@iseulde, @azaozz: What's missing here so the ticket can be closed?

#9 @iseulde
10 years ago

@ocean90 everything :) We only just improved the resizing for text.

This ticket was mentioned in Slack in #core by ocean90. View the logs.


10 years ago

#11 @ocean90
10 years ago

@iseulde, @azaozz: What's the plan here? Is there a follow-up commit which we can get into beta 1 tomorrow? I'm sure that the visual editor requires more testing.

#12 @ocean90
10 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.