WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#36488 closed defect (bug) (fixed)

Fix Grunt `precommit` task

Reported by: netweb Owned by: netweb
Priority: normal Milestone: 4.6
Component: Build/Test Tools Version: 4.5
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

Previously in #35557 via r36906 the task grunt precommit was added.

A minor issue in the original patch mistakenly called postcss:core for the precommit task.

The precommit task CSS sub task should call the precommit:css

FYI: The postcss:core task only calls precommit:css anyway, so it's not broken per se, but it's not inline with the purpose of the original patch and should be fixed to operate in the same fashion as the other precommit sub tasks.

Attachments (1)

36488.diff​ (542 bytes ) - added by netweb 10 years ago.

Download all attachments as: .zip

Change History (5)

@netweb
10 years ago

#1 @netweb
10 years ago

  • Milestone Future Release → 4.6
  • Owner set to netweb
  • Status new → accepted

#2 @SergeyBiryukov
10 years ago

  • Resolution → fixed
  • Status accepted → closed

Fixed in [37185].

#3 @netweb
10 years ago

  • Milestone 4.6

Ah, was to, thanks Sergey

#4 @SergeyBiryukov
10 years ago

  • Milestone → 4.6
Note: See TracTickets for help on using tickets.