WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#36488 closed defect (bug) (fixed)

Fix Grunt `precommit` task

Reported by: netweb's profile netweb Owned by: netweb's profile netweb
Milestone: 4.6 Priority: normal
Severity: normal Version: 4.5
Component: Build/Test Tools Keywords: has-patch commit
Focuses: Cc:

Description

Previously in #35557 via r36906 the task grunt precommit was added.

A minor issue in the original patch mistakenly called postcss:core for the precommit task.

The precommit task CSS sub task should call the precommit:css

FYI: The postcss:core task only calls precommit:css anyway, so it's not broken per se, but it's not inline with the purpose of the original patch and should be fixed to operate in the same fashion as the other precommit sub tasks.

Attachments (1)

36488.diff​ (542 bytes) - added by netweb 10 years ago.

Download all attachments as: .zip

Change History (5)

@netweb
10 years ago

#1 @netweb
10 years ago

  • Milestone changed from Future Release to 4.6
  • Owner set to netweb
  • Status changed from new to accepted

#2 @SergeyBiryukov
10 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed in [37185].

#3 @netweb
10 years ago

  • Milestone 4.6 deleted

Ah, was to, thanks Sergey

#4 @SergeyBiryukov
10 years ago

  • Milestone set to 4.6
Note: See TracTickets for help on using tickets.