WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#36489 closed enhancement (fixed)

Optimize Grunt `prerelease` task

Reported by: netweb Owned by: netweb
Priority: normal Milestone: 4.6
Component: Build/Test Tools Version: 4.5
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

Previously in #35557 via r36930 the task grunt prerelease was added.

Currently this task runs grunt build twice once when called in the task list as build and the other via the precommit:js task, which calls the qunit:compiled task in which build is a task of that task.

Removing the extra build task from the prerelease saves time by not running grunt build twice.

Attachments (1)

36489.diff​ (313 bytes ) - added by netweb 10 years ago.

Download all attachments as: .zip

Change History (3)

@netweb
10 years ago

#1 @netweb
10 years ago

  • Milestone Future Release → 4.6
  • Owner set to netweb
  • Status new → accepted

#2 @SergeyBiryukov
10 years ago

  • Resolution → fixed
  • Status accepted → closed

In 37206:

Build Tools: Don't run the build task twice in grunt prerelease (it already runs via the precommit:js task).

Props netweb.
Fixes #36489.

Note: See TracTickets for help on using tickets.