WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#36489 closed enhancement (fixed)

Optimize Grunt `prerelease` task

Reported by: netweb Owned by: netweb
Milestone: 4.6 Priority: normal
Severity: normal Version: 4.5
Component: Build/Test Tools Keywords: has-patch commit
Focuses: Cc:

Description

Previously in #35557 via r36930 the task grunt prerelease was added.

Currently this task runs grunt build twice once when called in the task list as build and the other via the precommit:js task, which calls the qunit:compiled task in which build is a task of that task.

Removing the extra build task from the prerelease saves time by not running grunt build twice.

Attachments (1)

36489.diff (313 bytes) - added by netweb 4 years ago.

Download all attachments as: .zip

Change History (3)

@netweb
4 years ago

#1 @netweb
4 years ago

  • Milestone changed from Future Release to 4.6
  • Owner set to netweb
  • Status changed from new to accepted

#2 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 37206:

Build Tools: Don't run the build task twice in grunt prerelease (it already runs via the precommit:js task).

Props netweb.
Fixes #36489.

Note: See TracTickets for help on using tickets.