Make WordPress Core

Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#36493 closed defect (bug) (fixed)

Move translator comment to the correct line

Reported by: SergeyBiryukov Owned by: christophherr
Priority: normal Milestone: 4.6
Component: I18N Version:
Severity: normal Keywords: good-first-bug has-patch
Cc: Focuses:

Description

In [36806], a translator comment was added for the string with a number instead of a string with a placeholder.

It should be moved one line below to be associated with the correct string.

Attachments (2)

36493.diff​ (746 bytes ) - added by christophherr 10 years ago.
Moves the translator comment above the string with a placeholder.
36493-2.diff​ (579 bytes ) - added by christophherr 10 years ago.
Adds the translator comment to both strings.

Download all attachments as: .zip

Change History (9)

#1 follow-up: @christophherr
10 years ago

I´m confused by the oneResult text string.
If 1 result is found, isn't it more like:
Use down arrow key to select the result?

#2 in reply to: ↑ 1 @SergeyBiryukov
10 years ago

Replying to christophherr:

I´m confused by the oneResult text string. If 1 result is found, isn't it more like: Use down arrow key to select the result?

I was confused for a bit as well, but now I think it's still correct. Down arrow key takes you to the result, and up arrow key takes you back to the input.

#3 @christophherr
10 years ago

Thank you. I see it now on the autocomplete demo.
Down arrow selects the autocomplete suggestion and up arrow switches back to the original input (unless you use left or right arrow key).
Navigate is probably not the most descriptive word for that but I agree it´s correct.

Looking at it on translate.wordpress.org I´d actually prefer to have the comment with each string.

@christophherr
10 years ago

Moves the translator comment above the string with a placeholder.

@christophherr
10 years ago

Adds the translator comment to both strings.

#4 @christophherr
10 years ago

  • Keywords has-patch added; needs-patch removed

#5 @DrewAPicture
10 years ago

  • Milestone Awaiting Review → 4.6
  • Owner set to christophherr
  • Status new → assigned

[Assigning ownership to mark the good-first-bug ticket as "claimed".]

#6 @SergeyBiryukov
10 years ago

  • Resolution → fixed
  • Status assigned → closed

In 37201:

I18N: Add translator comment for a string with a placeholder added in [36806].

Keep the comment for the string above too, for additional clarity.

Props christophherr.
Fixes #36493.

This ticket was mentioned in ​Slack in #core-i18n by sergey. ​View the logs.


10 years ago

Note: See TracTickets for help on using tickets.