WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#36502 closed defect (bug) (invalid)

The Jetpack Carousel viewer doesn't work after the Wordpress 4.5 update

Reported by: edvardtoth Owned by: joemcgill
Milestone: Priority: normal
Severity: normal Version: 4.5
Component: Gallery Keywords:
Focuses: javascript Cc:

Description

Following the 4.5 Wordpress update Jetpack Carousel (v3.9.6) is not launched when gallery-images are clicked on (this seems to affect other lightbox-type viewer plugins as well, like WP Featherlight).

Instead, the images go to their corresponding attachment pages.

This page is a good example: http://edvardtoth.com/art/personal-gallery/
It also demonstrates other Carousel functionality (caption on rollover) being broken too (the captions are permanently shown, instead of appearing on rollover).

The problematic behavior remains unchanged even when:

  • all other plugins are disabled
  • other themes are used
  • all caches are purged, minify is disabled, etc.

Change History (5)

#1 @DrewAPicture
3 years ago

  • Focuses javascript added
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Hi @edvardtoth,

Core Trac is used for tracking bugs in the core software itself. Until the Jetpack team has identified a core bug, your best bet is to post in the support forums for Jetpack to see if they've identified any incompatibilities with WordPress 4.5.

#2 @joemcgill
3 years ago

  • Owner set to joemcgill
  • Resolution changed from invalid to fixed

In 37879:

Media: Add action to display attachments on the edit screen.

This adds a new action hook, wp_edit_form_attachment_display to
edit_form_image_editor(), which can be used as a fallback to render
previews of an attachment that isn't an image, audio, or video file
included in the media library.

Props georgestephanis.
Fixes #36502.

#3 follow-up: @joemcgill
3 years ago

Gah. Wrong ticket. Intended for #36052.

Last edited 3 years ago by joemcgill (previous) (diff)

#4 in reply to: ↑ 3 @DrewAPicture
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to joemcgill:

Gah. Wrong ticket. Attended for #36052.

It's OK, you get another chance :-)

The @param line in the hook doc is missing the variable reference:

  • Version

     
    27712771    /**
    27722772     * Fires when attachment type can't be rendered in the edit form.
    27732773     *
    27742774     * @since 4.6.0
    27752775     *
    2776      * @param WP_Post A post object.
     2776     * @param WP_Post $post A post object.
    27772777     */
    27782778    do_action( 'wp_edit_form_attachment_display', $post );

#5 @joemcgill
3 years ago

  • Resolution set to invalid
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.