Having only a single theme overflows the container

[hardeepasrani]

Hey guys,

In WordPress, here's how the Theme page is looking is there's only a single theme and the menu is collapsed:

​https://nimbus.everhelper.me/client/notes/share/444111/mm5yx25gxxlhbwlgn56v

I tested with various sites and it was happening even before 4.5 update.

I've attached CSS patch which fixes this (hope it's good) and also tested it with RTL. Here's how it looks after this:

​https://nimbus.everhelper.me/client/notes/share/444113/qxl4l6z51ilnmd4t4mwb

Hope this helps.

[hardeepasrani]

Edits both minfied and complete files, ltr and rtl.

[hardeepasrani]

This one doesn't edit minified versions.

[SergeyBiryukov]

Hi @hardeepasrani, thanks for the ticket.

No need to patch minified or RTL files, a build task takes care of that.

[hardeepasrani]

Just the themes.css file

[hardeepasrani]

Is this one alright?

[obenland]

We should probably just removed this rule.

[hardeepasrani]

Let me see what happens if we do that.

[hardeepasrani]

@obenland

If we remove that part then this happens when you've multiple themes and you click on one to see the pop-up: ​https://nimbus.everhelper.me/client/notes/share/444184/p60nhl145p2l26ecpt00

[obenland]

Good point. Let's make that selector more specific then. See 36504.diff​.

[hardeepasrani]

That works.

[DrewAPicture]

Can we get screenshots with the patch applied?

[hardeepasrani]

When Dashboard menu is open.

[hardeepasrani]

When Dashboard menu is closed.

[hardeepasrani]

@DrewAPicture Will this do or should I add when there are multiple themes as well? :)

[DrewAPicture]

@hardeepasrani: Seems like the fix is specifically for a single theme overflowing the container, but yeah, adding a screenshot showing that the listing for multiple themes is still displaying as expected would probably be good too.

[hardeepasrani]

With multiple themes.

[hardeepasrani]

There you go. :)

[obenland]

In 37205:

Themes: Fix single theme modal on collapsed menu.

Prevents the modal from being displayed off screen, when there is only one
theme available and the menu is collapsed.

Props hardeepasrani for initial patch.
Fixes #36504.