WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#36504 closed defect (bug) (fixed)

Having only a single theme overflows the container

Reported by: hardeepasrani Owned by: obenland
Milestone: 4.6 Priority: normal
Severity: normal Version: 4.6
Component: Themes Keywords: has-patch has-screenshots
Focuses: ui, administration Cc:

Description

Hey guys,

In WordPress, here's how the Theme page is looking is there's only a single theme and the menu is collapsed:

https://nimbus.everhelper.me/client/notes/share/444111/mm5yx25gxxlhbwlgn56v

https://box.everhelper.me/attachment/444111/e7277488-c805-4a5f-bd39-050817599257/542868-Prdg5OwG68fHqo8c/screen.png

I tested with various sites and it was happening even before 4.5 update.

I've attached CSS patch which fixes this (hope it's good) and also tested it with RTL. Here's how it looks after this:

https://nimbus.everhelper.me/client/notes/share/444113/qxl4l6z51ilnmd4t4mwb

https://box.everhelper.me/attachment/444113/e7277488-c805-4a5f-bd39-050817599257/542868-rb2Ychg0Jt4J6d6J/screen.png

Hope this helps.

Attachments (7)

theme-css.diff (115.1 KB) - added by hardeepasrani 3 years ago.
Edits both minfied and complete files, ltr and rtl.
themes-css.diff (709 bytes) - added by hardeepasrani 3 years ago.
This one doesn't edit minified versions.
themes-css.2.diff (348 bytes) - added by hardeepasrani 3 years ago.
Just the themes.css file
36504.diff (381 bytes) - added by obenland 3 years ago.
Menu Open.png (594.1 KB) - added by hardeepasrani 3 years ago.
When Dashboard menu is open.
Menu Collapsed.png (681.3 KB) - added by hardeepasrani 3 years ago.
When Dashboard menu is closed.
multiple themes.gif (2.3 MB) - added by hardeepasrani 3 years ago.
With multiple themes.

Change History (22)

@hardeepasrani
3 years ago

Edits both minfied and complete files, ltr and rtl.

@hardeepasrani
3 years ago

This one doesn't edit minified versions.

#1 @SergeyBiryukov
3 years ago

  • Component changed from General to Themes

Hi @hardeepasrani, thanks for the ticket.

No need to patch minified or RTL files, a build task takes care of that.

@hardeepasrani
3 years ago

Just the themes.css file

#2 @hardeepasrani
3 years ago

Is this one alright?

#3 @hardeepasrani
3 years ago

  • Summary changed from Having on a single theme overflows the container to Having only a single theme overflows the container

#4 @swissspidy
3 years ago

  • Keywords has-patch needs-testing added

#5 @obenland
3 years ago

  • Keywords needs-refresh added; needs-testing removed

We should probably just removed this rule.

#6 @hardeepasrani
3 years ago

Let me see what happens if we do that.

#7 @hardeepasrani
3 years ago

@obenland

If we remove that part then this happens when you've multiple themes and you click on one to see the pop-up: https://nimbus.everhelper.me/client/notes/share/444184/p60nhl145p2l26ecpt00

https://box.everhelper.me/attachment/444184/e7277488-c805-4a5f-bd39-050817599257/542868-rIcYdYhrrkoggGcZ/screen.png

@obenland
3 years ago

#8 @obenland
3 years ago

  • Keywords needs-refresh removed

Good point. Let's make that selector more specific then. See 36504.diff.

#9 @hardeepasrani
3 years ago

That works.

#10 @swissspidy
3 years ago

  • Milestone changed from Awaiting Review to 4.6

#11 @DrewAPicture
3 years ago

  • Focuses ui added
  • Keywords needs-screenshots added

Can we get screenshots with the patch applied?

@hardeepasrani
3 years ago

When Dashboard menu is open.

@hardeepasrani
3 years ago

When Dashboard menu is closed.

#12 @hardeepasrani
3 years ago

@DrewAPicture Will this do or should I add when there are multiple themes as well? :)

#13 @DrewAPicture
3 years ago

  • Keywords has-screenshots added; needs-screenshots removed

@hardeepasrani: Seems like the fix is specifically for a single theme overflowing the container, but yeah, adding a screenshot showing that the listing for multiple themes is still displaying as expected would probably be good too.

@hardeepasrani
3 years ago

With multiple themes.

#14 @hardeepasrani
3 years ago

There you go. :)

#15 @obenland
3 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 37205:

Themes: Fix single theme modal on collapsed menu.

Prevents the modal from being displayed off screen, when there is only one
theme available and the menu is collapsed.

Props hardeepasrani for initial patch.
Fixes #36504.

Note: See TracTickets for help on using tickets.