WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#36573 closed enhancement (fixed)

Add `$comment` parameter to `get_comment_author_url_link()`

Reported by: flixos90 Owned by: wonderboymusic
Milestone: 4.6 Priority: normal
Severity: normal Version: 1.5
Component: Comments Keywords: has-patch needs-unit-tests
Focuses: Cc:

Description

To use this function (also its related output function) for any specific comment, let's add a $comment parameter.

Related: #36571

Attachments (3)

36573.diff (3.3 KB) - added by flixos90 2 years ago.
Patch adding the new parameter
36573.2.diff (3.3 KB) - added by flixos90 2 years ago.
docs update
36573.3.diff (3.3 KB) - added by flixos90 2 years ago.
docs update

Download all attachments as: .zip

Change History (7)

@flixos90
2 years ago

Patch adding the new parameter

#1 @flixos90
2 years ago

  • Keywords has-patch added

#2 @swissspidy
2 years ago

  • Keywords needs-unit-tests added

Minor docs nitpicking: We usually use The xy parameter was added. instead of The xy argument was added..

A parameter is the variable which is part of the method’s signature, whereas an argument is an expression used when calling the method.

Unfortunately it's not used consistently in core (69x parameter, 16x argument).

@flixos90
2 years ago

docs update

@flixos90
2 years ago

docs update

#3 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 4.6

#4 @wonderboymusic
2 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 37305:

Comments: add a $comment parameter to get_comment_author_url_link().

Add unit tests (none exist).

Props flixos90, wonderboymusic.
Fixes #36573.

Note: See TracTickets for help on using tickets.