WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 days ago

#36612 closed enhancement (fixed)

Add Ratings into the Add New Theme page

Reported by: dd32 Owned by: desrosj
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch has-screenshots commit
Focuses: ui Cc:

Description

Currently when searching for themes, we display the average rating but no link or ability to view what those reviews are.

We should provide a way to view ratings when previewing the theme in the installer.

I don't have a UI in mind for this, or an idea where it'd fit, but without it the average rating of the theme is a little "magic" as there's no way to see why it's rated that way.

Attachments (12)

Mock-up_read_reviews.jpg (212.1 KB) - added by Travel_girl 3 years ago.
Mock-up Read Reviews
Artboard 1.jpg (213.7 KB) - added by Travel_girl 3 years ago.
Mock-up Read Reviews
theme-review_info.png (600.2 KB) - added by Marco Peralta 3 years ago.
theme-reviews-description
theme-review_review.png (503.9 KB) - added by Marco Peralta 3 years ago.
theme-reviews-review
Mockup.jpg (306.8 KB) - added by Ixium 3 years ago.
Mockup
Mockup2.jpg (132.7 KB) - added by Ixium 3 years ago.
current view.png (1.5 MB) - added by Travel_girl 2 years ago.
Current view
Rating_in_Details.png (522.5 KB) - added by Travel_girl 2 years ago.
Rating in Details in current view
36612.diff (855 bytes) - added by celloexpressions 8 months ago.
Add a (hardcoded) link to view ratings on WordPress.org to the theme browser in the customizer
36612.api.diff (820 bytes) - added by celloexpressions 8 months ago.
Add a link (which needs to be returned by the .org themes API) to view theme ratings
36612.2.diff (1.3 KB) - added by celloexpressions 8 months ago.
Add a link to view theme ratings, loading the link from the .org API.
36612.2.png (652.8 KB) - added by celloexpressions 8 months ago.
With 36612.2.diff

Change History (44)

This ticket was mentioned in Slack in #design by travelgirl. View the logs.


3 years ago

@Travel_girl
3 years ago

Mock-up Read Reviews

@Travel_girl
3 years ago

Mock-up Read Reviews

#3 in reply to: ↑ 2 @Ixium
3 years ago

Replying to Travel_girl:

What about this Design?

https://core.trac.wordpress.org/attachment/ticket/36612/Artboard%201.jpg

I like the idea, although i think it's a nice feature to also show some short excerpts with a read more >> link.

@Marco Peralta
3 years ago

theme-reviews-description

@Marco Peralta
3 years ago

theme-reviews-review

#4 @Marco Peralta
3 years ago

I thought about an approach similar to what is on wordpress.org - so we could have tabs and different kinds of info about a theme. I made a quick mockup about my idea so we can discuss it. This way anyone can have access to all info they can get (even if with some external links to wordpress.org eventually)

See attachments above...

theme-review_info.png - https://core.trac.wordpress.org/attachment/ticket/36612/theme-review_info.png
and theme-review-review.png - https://core.trac.wordpress.org/attachment/ticket/36612/theme-review_review.png

P.S: i don't think the "Support" tab is necessarily a great idea to have in here, but still on the 1st mockup for further discussion

Last edited 3 years ago by Marco Peralta (previous) (diff)

@Ixium
3 years ago

Mockup

#5 @Ixium
3 years ago

I was thinking about a design like this one above... A short description with a read more-link and the reviews below it with read more-links

#6 @Travel_girl
3 years ago

I like this Version:

https://core.trac.wordpress.org/attachment/ticket/36612/theme-review_review.png

Although I think so too, that the support-tab is not really necessary and to many option are might a bit too many informations.

for this example:

https://core.trac.wordpress.org/attachment/ticket/36612/Mockup.jpg

I think the description from the Theme is more important than the reviews.

@Ixium
3 years ago

#7 @Ixium
3 years ago

you are right. The description is more important. > maybe make it all collapsible like the above mockup :)

#8 @karmatosed
3 years ago

I think having the reviews collapsable and the description showing makes sense. Both collapsing feels a little too much.

@Travel_girl
2 years ago

Current view

@Travel_girl
2 years ago

Rating in Details in current view

#9 @Travel_girl
2 years ago

Because the current Design changed, I made a new mockup.

I´m not sure if we need the Text "4.5 out of 5 Stars".

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


18 months ago

#11 @joyously
18 months ago

I would prefer the rating to be downplayed if there is no way to tell why the user rated it the way they did.

#12 @melchoyce
18 months ago

Let's go with Rating_in_Details.png. Worth showing the rating on installed themes, or just when browsing themes?

#13 @poena
18 months ago

I think it would be good to have it for the installed themes too, because it might increase the number of ratings a theme receives.

#14 follow-up: @celloexpressions
18 months ago

  • Keywords needs-design added

To clarify, Rating_in_Details.png is what this looks like in the customizer. The earlier mockups are the wp-admin version (via themes.php), which still exists. I suggest focusing on the customizer integration first, as the other version would move closer to the newer customize design if it's changed in the future.

The stars and number of ratings are already displayed here when browsing WordPress.org themes that have ratings (this information is not readily available for installed themes, and probably isn't worth additional API calls to check if a theme came from .org). I was not able to find a public API that exposed the actual reviews the last time I tried implementing this - is that available or documented anywhere @dd32? The next step is designing the interaction to expand the ratings and the actual ratings display.

This would be nice to have for 4.9 with the new interface, but it's a bit late. If there's a design this week and an API exists from .org, it may be doable before beta 3 if we want to try to get it in.

#15 @dd32
18 months ago

I was not able to find a public API that exposed the actual reviews the last time I tried implementing this - is that available or documented anywhere @dd32?

AFAIK no, there's no API at present for Theme Reviews.
It could be added to the /themes/info/1.1/ API in a similar manner as to how it's exposed in the plugins API with a small bit of work. However, as there's no reviews shown on the WordPress.org/themes/ pages there's no existing work that can be done to simply "enable" it in the API.

#16 in reply to: ↑ 14 @Travel_girl
18 months ago

The next step is designing the interaction to expand the ratings and the actual ratings display.

I would not expand the ratings, because in my opinion it makes to much noise. I would suggest to add a (underlined) link to the Text "4.5 out of 5 stars." which links to the rating details on wordpress.org/themes.

In the similar way the plugins details are linked as well.

Last edited 18 months ago by Travel_girl (previous) (diff)

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


9 months ago

#18 @karmatosed
9 months ago

  • Keywords has-ui-feedback added; ui-feedback removed

Looks like this has feedback so let's mark it as such.

#19 @celloexpressions
9 months ago

  • Component changed from Upgrade/Install to Customize
  • Focuses ui added
  • Keywords good-first-bug added; needs-design removed
  • Milestone changed from Awaiting Review to Future Release

Next step is a patch to add a link to view the ratings on WordPress.org to the ratings in the theme details modals in the customizer, as suggested in 16.

@celloexpressions
8 months ago

Add a (hardcoded) link to view ratings on WordPress.org to the theme browser in the customizer

@celloexpressions
8 months ago

Add a link (which needs to be returned by the .org themes API) to view theme ratings

#20 follow-up: @celloexpressions
8 months ago

  • Keywords has-patch added; needs-patch has-ui-feedback good-first-bug removed
  • Milestone changed from Future Release to 4.9.9

36612.diff links the ratings text in the theme details modal to wordpress.org. This appears to work; however, it would probably be better if the .org API can return a link to the ratings (not sure how this works for other languages, for example). 36612.api.diff covers the core changes to facilitate that approach.

@dd32 can you weigh in on the preferred strategy and adjust the .org themes API as needed? This would be a nice improvement to bring into a minor release in the near future, depending on any API needs.

#21 in reply to: ↑ 20 @dd32
8 months ago

Replying to celloexpressions:

@dd32 can you weigh in on the preferred strategy and adjust the .org themes API as needed? This would be a nice improvement to bring into a minor release in the near future, depending on any API needs.

Lets add the reviews_url field to the API so as to not need to manually build it.

https://meta.trac.wordpress.org/changeset/7467 adds the support for it.

It's included by default in the info/1.2 API but 4.9 (which uses the info/1.1 api) will need to pass the reviews_url field - you'll find it's already sending the num_ratings field for that.

Here's example requests:

@celloexpressions
8 months ago

Add a link to view theme ratings, loading the link from the .org API.

@celloexpressions
8 months ago

With 36612.2.diff

#22 @celloexpressions
8 months ago

  • Keywords has-screenshots commit added

Thanks for adding an API field to support this. 36612.2.diff should be ready to go to use this (see screenshot above). Note that the link has to open in a new tab because the customizer can be opened in an iframe; the screen reader text warns users of this.

It looks like trunk may still be pulling from version 1.1 of the API; either way, this patch would work for 4.9.X, then we can adjust for trunk if it switches to 1.2. We can just exclude the changes to wp-includes/class-wp-customize-manager.php.

#23 @pento
6 months ago

  • Milestone changed from 4.9.9 to 5.0.1

#24 @pento
3 months ago

  • Milestone changed from 5.0.1 to 5.0.2

#25 @pento
3 months ago

  • Milestone changed from 5.0.2 to 5.0.3

#26 @desrosj
3 months ago

  • Milestone changed from 5.0.3 to 5.1

This falls outside of the 5.0.3 priorities. Let's punt to 5.1.

#27 @pento
2 months ago

  • Keywords needs-testing added; commit removed

@celloexpressions: Could you test 36612.2.diff on trunk and confirm that it's working properly?

#28 @pento
2 months ago

  • Milestone changed from 5.1 to 5.2

#29 @desrosj
4 days ago

  • Milestone changed from 5.2 to 5.3

This still requires testing.

#30 @celloexpressions
3 days ago

  • Keywords commit added; needs-testing removed
  • Milestone changed from 5.3 to 5.2

36612.2.diff still works for me. Nothing has changed since I marked this for commit 8 months ago, other than a string of punts.

Theoretically, the changes to wp-includes/class-wp-customize-manager.php could be omitted if this is not backported to 4.9.X; however, this change would not negatively impact the feature's ability to function. Keeping the patch as-is ensures that the adjustment should work regardless of the .org API version used.

#31 @desrosj
3 days ago

  • Owner set to desrosj
  • Status changed from new to reviewing

Thanks for confirming, @celloexpressions!

#32 @SergeyBiryukov
2 days ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 44975:

Customize: Add a link to theme reviews in the theme details modal in the Customizer and on Add Themes screen.

Props celloexpressions, Travel_girl, Ixium, marco-peralta, dd32.
Fixes #36612.

Note: See TracTickets for help on using tickets.