Make WordPress Core

Opened 22 months ago

Last modified 9 months ago

#36627 new defect (bug)

Theme preview/details: change non-links to buttons and remove disabled buttons from tabindex

Reported by: walbo Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch needs-refresh semantic-buttons
Focuses: accessibility, javascript Cc:


The next/prev theme navigation gets the classname .disabled but is still available in the tabindex. Also the navigation is non-links <a href="#"> that should be <button>.

If you previewing a installed theme, there is a non-link thats says installed. The link should not be a link.

Attachments (2)

36627.patch (5.5 KB) - added by walbo 22 months ago.
36627.02.patch (5.5 KB) - added by walbo 22 months ago.

Download all attachments as: .zip

Change History (5)

22 months ago

#1 @walbo
22 months ago

  • Keywords has-patch added

22 months ago

#2 @afercia
19 months ago

  • Focuses javascript added
  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to Future Release

Thanks @walbo yes the theme browser needs some accessibility improvements and many of the points you outlined are perfectly valid. Many things have changed in the last months, see for example [38084] that added a disabled attribute on the next/prev navigation to take them out from the tab order when they're... disabled :)

Other things need to be fixed yet, for example some buttons miss a type="button" attribute and the JS part could be probably simplified. Also, some links (with a few exceptions for the ones that still work when JS is off) need to be buttons.

I'd suggest to keep things separated though and open a separate ticket for the theme installer. Keeping the issues related to the theme browser in this ticket and addressing the theme installer issues in a separate ticket would help to make things more clear for other contributors and reviewers.

#3 @afercia
9 months ago

  • Keywords semantic-buttons added
Note: See TracTickets for help on using tickets.