ngettext dislikes formatted numbers

[nbachiyski]

What happens:
If the number of comments, posts or cats in the Dashboard is greater than a thousand and the current locale has defined different from default plural rules the <code>ngettext</code>

function spits an error.

Why:
The aforementioned numbers are passed through <code>number_format</code> before usage, which adds a coma between digits groups. Thus the number is no more the valid number, <code>ngettext</code> expects.

Solution:
Could we sacrifice the formatting of the numbers? If we could the patch below is relevant.

[markjaquith]

Patch for trunk

[markjaquith]

Why can't we pass non-number_format()'d version to ngettext and then use the number_format()'d version in the sprintf() ? See patch.

Also... shouldn't we provide a function like ___number_format() so that translators can provide for a locale's number formatting? For instance, in India they format numbers differently. (open a separate ticket if you agree)

[nbachiyski]

Replying to markjaquith:

Why can't we pass non-number_format()'d version to ngettext and then use the number_format()'d version in the sprintf() ? See patch.

Also... shouldn't we provide a function like ___number_format() so that translators can provide for a locale's number formatting? For instance, in India they format numbers differently. (open a separate ticket if you agree)

That is why I wanted to remove the formatting. It will be a little burden for translators to dig into number_format options. On the other side it would be nice to have formatted numbers. If you say so, we will arange the things for translators :-)

[markjaquith]

Well, lets fix the bug first (the sending of formatted numbers to ngettext()) and I'll open a ticket to explore i18n of number formatting.

[markjaquith]

(In [4808]) Do not pass comma-formatted numbers to ngettext(). Props nbachiyski. fixes #3663

[markjaquith]

#3677 is the ticket for i18n of number_format()

[dtc]

Bug reintroduced in WP 2.1.2.

[markjaquith]

Bug was fixed in trunk only, so the fix won't show up in a release version until 2.2 is released in April.