Opened 19 years ago
Closed 19 years ago
#3665 closed defect (bug) (fixed)
typo in wp-trackback
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 2.2 | Priority: | low |
| Severity: | minor | Version: | 2.1 |
| Component: | General | Keywords: | trackback has-patch |
| Focuses: | Cc: |
Description
This doesn't seem to be causing any problems, but it doesn't look right. (my comment added)
if (empty($title) && empty($tb_url) && empty($blog_name)) {
// If it doesn't look like a trackback at all...
wp_redirect(get_permalink($tb_id));
exit;
}
/** second !empty($tb_url) is unecessary, SHOULD BE $blog_name or ?? **/
if ( !empty($tb_url) && !empty($title) && !empty($tb_url) ) {
header('Content-Type: text/xml; charset=' . get_option('blog_charset') );
Attachments (1)
Change History (4)
Note: See
TracTickets for help on using
tickets.
It looks like it should be
$blog_nameBut according to the TrackBack spec,
blog_name,excerpt, andtitleare all optional. The only required field isurlFor now, I'd just remove the redundant check.