Make WordPress Core

Opened 17 years ago

Closed 17 years ago

#3665 closed defect (bug) (fixed)

typo in wp-trackback

Reported by: mittineague's profile Mittineague Owned by: markjaquith's profile markjaquith
Milestone: 2.2 Priority: low
Severity: minor Version: 2.1
Component: General Keywords: trackback has-patch
Focuses: Cc:

Description

This doesn't seem to be causing any problems, but it doesn't look right. (my comment added)

if (empty($title) && empty($tb_url) && empty($blog_name)) {
	// If it doesn't look like a trackback at all...
	wp_redirect(get_permalink($tb_id));
	exit;
}
/** second !empty($tb_url) is unecessary, SHOULD BE $blog_name or ?? **/
if ( !empty($tb_url) && !empty($title) && !empty($tb_url) ) {
	header('Content-Type: text/xml; charset=' . get_option('blog_charset') );

Attachments (1)

wp-trackback.php.diff (471 bytes) - added by markjaquith 17 years ago.

Download all attachments as: .zip

Change History (4)

#1 @markjaquith
17 years ago

  • Milestone changed from 2.3 to 2.2
  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

It looks like it should be $blog_name

But according to the TrackBack spec, blog_name, excerpt, and title are all optional. The only required field is url

For now, I'd just remove the redundant check.

#2 @markjaquith
17 years ago

  • Keywords has-patch added

Patch removes redundant check. Does not change functionality.

#3 @ryan
17 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4801]) Remove redundant check. Props Mittineague. fixes #3665

Note: See TracTickets for help on using tickets.