Opened 8 years ago
Closed 8 years ago
#36658 closed enhancement (fixed)
Adding method to reset the mocked phpmailer instance
Reported by: | welcher | Owned by: | boonebgorges |
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch dev-feedback |
Focuses: | Cc: |
Description
Added a new decorator method to rest the mock phpmailer object to make it more clear as to what the code is doing. Also, I removed the tests_
prefix from the retrieve_phpmailer_instance
method as it is not needed and may cause confusion as it does not contain any tests.
Attachments (2)
Change History (7)
Note: See
TracTickets for help on using
tickets.
The reset method looks good to me.
I think the
tests_
prefix on the function is meant to be a namespace - seetests_add_filter()
. I am wary of changing it just for aesthetic reasons, as there may be third-party libraries using it. Could you change it back and post an updated patch?