WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #36697, comment 25


Ignore:
Timestamp:
11/01/2016 08:50:53 AM (4 years ago)
Author:
curdin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #36697, comment 25

    initial v1  
    11@westonruter Can I have your opinion please? I've been working on this for a bit today and wanted to check if backwards compatibility in this case is strictly necessary. The reason is that the code could be simplified if we dropped compatibility. Eg see patch with backwards compatibility https://github.com/curdin/wordpress-develop/pull/1 vs patch without, where the ajax handler always expects an array of itemTypes https://github.com/curdin/wordpress-develop/pull/2
    22
    3 I'm not clear how widespread use for this function is outside core so looking for your expert opinion.
     3I'm not clear how widespread use for this function is outside core so looking for your expert opinion. I'll need to do some more work on whatever the preferred approach is.