Symlinked plugin path incorrectly registered during uninstall

[andy]

The dirname() shouldn't be here in uninstall_plugin():

		wp_register_plugin_realpath( WP_PLUGIN_DIR . '/' . dirname( $file ) );

wp_register_plugin_realpath() calls dirname( $file ); to remove the basename. The basename must be included in the argument or the symlinked directory won't be registered. Then, if uninstall.php does this check it will fail:

if ( dirname( WP_UNINSTALL_PLUGIN ) != dirname( plugin_basename( __FILE__ ) ) )
  exit();

This was observed while trying to uninstall Jetpack which was installed as a symlink. The result was a WSOD. Removing the dirname() from uninstall_plugin() fixes the path registration and allows the check to pass.

[ocean90]

Introduced in [27158].

[ocean90]

In 37331:

Plugins: In uninstall_plugin() pass the plugin file to wp_register_plugin_realpath().

wp_register_plugin_realpath() calls dirname( $file ); to remove the basename. The basename must be included in the argument or the symlinked directory won't be registered.

Props andy.
Fixes #36709.