WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #36717, comment 31


Ignore:
Timestamp:
06/09/2016 07:22:50 PM (3 years ago)
Author:
flixos90
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #36717, comment 31

    initial v1  
    1111> * It may be that we'll be ready to deprecate `get_blog_details()` in the near future or at least stop relying on it. If we treat #36935 as something entirely different—maybe with new cache keys—then `get_sites()` / `get_site()` could be used instead. Maybe a last modified needs to be added to the key to help with future invalidation.
    1212
    13 Where exactly do we store `WP_Site` in cache? Are there other locations than `get_blog_details()`? I generally think we should switch to storing plain `stdClass` everywhere to prevent issues like the above in the future. I agree that new cache keys for the `get_details()` method in #36935 would totally make sense as a first step.
     13Where exactly do we store `WP_Site` in cache? Are there other locations than `get_blog_details()`? I generally think we should switch to storing plain `stdClass` everywhere to prevent issues like the above in the future. I agree that new cache keys for the `get_details()` method in #36935 would totally make sense as a first step. Actually, if we use new cache keys, we wouldn't need to do the changes in your first bullet point, do I get that right?