#3673 closed defect (bug) (worksforme)
Theme editing loading css file of when select php file of different name
Reported by: | AndyBeard | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 2.1.2 |
Component: | General | Keywords: | |
Focuses: | Cc: |
Description
I mainly edit themes offline but sometimes when just adding a widget to a sidebar I use the online editors.
This URL seems to be formatted correctly, however it brings up style.css
Comparing the URL to one on another blog running 2.07 and has the same theme uploaded (and works correctly with online editing).
It is easy enough to edit offline, but it effectively makes the oline editor only usable for CSS changes.
Attachments (1)
Change History (14)
#1
@
17 years ago
- Milestone changed from 2.1.1 to 2.2
- Priority changed from high to normal
- Severity changed from major to normal
- Summary changed from Theme editing online broken to Theme editing loading css file of when select php file of different name
#3
@
17 years ago
Switching off all plugins and clearing cache didn't fix it. Had to wait for a litle free time with low traffic.
Switching to another theme and back again seems to have worked, thus maybe something is some data is stored in a different place now that affects it?
System had been updated 2.07 > 2.1 rc2 > 2.1 release
Operating system Linux
Kernel version 2.6.17.11-grsechg
Machine Type i686
Apache version 1.3.37 (Unix)
PERL version 5.8.7
PHP version 4.4.4
MySQL version 4.1.21-standard
Firefox 2.0.0.1 running AMD/WinXp Home box
#4
@
17 years ago
AndyBeard, thank you for the additional details! And I am happy that you worked around it.
Lets see if how many others encounter this issue to see if there is more to this pattern, and to see how many people it impacts. If quite a few may be worth while if nothing else adding some debug code.
#5
@
17 years ago
- Resolution set to worksforme
- Status changed from new to closed
Closing as worksforme, can always be reopened if the problem reoccurs.
#7
@
17 years ago
- Resolution worksforme deleted
- Status changed from closed to reopened
- Version changed from 2.1 to 2.1.2
I can't really explain since register_globals is ON but I solved this issue in adding in the theme-editor.php and template.php the following line before using the $file variable:
$file = $_GETfile?;
PHP 4.3.11 - register_globals = ON
#8
@
17 years ago
There was a formatting issue in my previous post. The line is:
$file = $_GET['file'];
#10
@
17 years ago
Perhaps there is some sort of extra PHP security layer zero'ing out $file
which would explain ngruloos' solution. It does sound like a query var that could lead to register_globals type security breaches.
Our code that populates $file
only does so if $file
isn't already set... so if something else were setting it, that could be the problem.
#12
@
16 years ago
- Resolution set to worksforme
- Status changed from reopened to closed
Not enough info here to reproduce and no new info in a while.
The suggested change makes no logical sense and the php info doesn't show signs of any php security extensions being enabled.
Marking as worksforme for now.
Please re-open with reproduction info if you have it.
Hi Andy Beard,
That is very strange. I can't reproduce this problem. I even installed the same theme. I have found no other reports of this. Can you reproduce it with browser cache cleared and all your plugins disabled?
Also, can you provide the general details about your client (browser) and server environment?