WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#36741 closed defect (bug) (fixed)

Store `WP_Date_Query` instance in class property of `WP_Comment_Query`

Reported by: flixos90 Owned by: boonebgorges
Milestone: 4.6 Priority: normal
Severity: minor Version: 3.1
Component: Comments Keywords: has-patch
Focuses: Cc:

Description

WP_Comment_Query has a class property $date_query which is supposed to hold the WP_Date_Query instance used by the main query, but it currently is not used at all. It's only used inside a class method at this point, however the date query instance should actually be available through the class property I think.

Attachments (1)

36741.diff (958 bytes) - added by flixos90 4 years ago.
patch stores date query in class property

Download all attachments as: .zip

Change History (4)

@flixos90
4 years ago

patch stores date query in class property

#1 @flixos90
4 years ago

  • Keywords has-patch added

#2 @boonebgorges
4 years ago

  • Milestone changed from Awaiting Review to 4.6
  • Severity changed from normal to minor

Thanks for the patch!

#3 @boonebgorges
4 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 37354:

date_query should be a property on WP_Comment_Query objects.

Instead of a local variable.

Props flixos90.
Fixes #36741.

Note: See TracTickets for help on using tickets.