Apply new Dashicon to Multisite

[Ipstenu]

Back in 4.3 (see #30902) we added a new icon for Multisite.

We've never added it to WordPress core.

This patch does just that, replacing the key with the houses.

[johnjamesjacoby]

Would ya look at that. I'm +1 on this.

[ocean90]

@Ipstenu You should use develop.svn.wordpress.org because you don't have to patch RTL files. These are generated by our build tools.

[Ipstenu]

built from develop

[Ipstenu]

Toolbar change - before and after

[Ipstenu]

Dashboard change

[Ipstenu]

Added images and (theoretically) the patch from the right place.

[johnjamesjacoby]

Replying to Ipstenu:

Added images and (theoretically) the patch from the right place.

New patch looks perfect to my eyes.

[jeremyfelt]

36754.4.diff​ catches .dashicons-admin-network:before as well, which is what was displaying the sidebar icon for me. I've lost track of where .icon16.icon-site is applied, but changing it there makes sense.

[jeremyfelt]

In 37362:

Multisite: Use the admin-multisite Dashicon in the admin menu and bar

This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Props Ipstenu.
Fixes #36754.

[ocean90]

dashicons.css is an external-ish file and shouldn't be changed in core without changing it ​upstream too.

The class for the new icon is .dashicons-admin-multisite and should be used for the menu instead, see 37362.patch​.

[johnjamesjacoby]

Replying to ocean90:

dashicons.css is an external-ish file and shouldn't be changed in core without changing it ​upstream too.

The class for the new icon is .dashicons-admin-multisite and should be used for the menu instead, see 37362.patch​.

Ugh. I totally forgot about that.

Your patch seems incorrect, unless I'm reading it wrong. We do not want to change the network dashicon (in dashicons.css), we only want to implement the multisite dashicon where it was intended (in menus and such.)

[johnjamesjacoby]

Nevermind; I am reading it wrong.

@jeremyfelt slipped in a new patch that changed the network icon. That should get reverted in favor of a portion of @Ipstenu's patch upstream to Github, and @ocean90's patch will rebase core for now, too.

[jeremyfelt]

In 37364:

Revert [37362], which incorrectly changed Dashicons CSS

dashicons.css is an external-ish library and the change there is incorrect.

See #36754.

[jeremyfelt]

Ok. Reverted to restart as an entire changeset. :)

36754.2.diff​ applies the menu change, the #wpadminbar #wp-admin-bar-site-name > .ab-item:before change, and the .icon16.icon-site:before change.

Is icon16 just for back-compat?

[ocean90]

Replying to jeremyfelt:

Is icon16 just for back-compat?

Yep. 36754.2.diff​ looks good.

[jeremyfelt]

In 37365:

Multisite: Use the admin-multisite Dashicon for sites

This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Uses the more appropriate dashicons-admin-multisite when displaying the sites menu item.

Props Ipstenu, ocean90.
Fixes #36754.