WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#36759 closed enhancement (fixed)

Upgrade MediaElement to 2.21.2

Reported by: flyplugins Owned by: ocean90
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: has-patch needs-testing
Focuses: Cc:
PR Number:

Description

Media Elements JS will not play YouTube video's on FireFox v44. This is a known issue by Media Elements JS and is fixed with version 2.19.0. Here is a direct link to the known issue: https://github.com/johndyer/mediaelement/issues/1684. Is it possible to get Media Elements in WP Core updated from 2.18.1 to latest which does resolve the issue?

Attachments (1)

36759.diff (158.5 KB) - added by swissspidy 3 years ago.

Download all attachments as: .zip

Change History (11)

#1 @swissspidy
3 years ago

The current version of MediaElement.js is 2.21.2. Does that version indeed solve the issue with YouTube videos? Because the issue you linked to is still open and hasn't been updated since April.

#2 @swissspidy
3 years ago

  • Component changed from General to External Libraries

#3 @flyplugins
3 years ago

Yes, 2.21.2 does solve the issue.

I've setup an example in which I dequeue/deregister the current version of MEJS and enqueue the working version. Simply open FireFox and navigate to:

http://s3mm.staging.wpengine.com/youtube-example-with-mejs-version-2-21-2/ <--Issue resolved with 2.21.2
http://s3mm.staging.wpengine.com/youtube-example-with-mejs-version-2-18-1/ <--Issue exists with 2.18.1

Shortcode examples are listed on page.

@swissspidy
3 years ago

#4 @swissspidy
3 years ago

  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to 4.6
  • Summary changed from MediaElements JS Player Bug with YouTube on FireFox to Upgrade MediaElement to 2.21.2
  • Type changed from defect (bug) to enhancement

#5 @ocean90
3 years ago

  • Owner set to ocean90
  • Status changed from new to accepted
  • Version trunk deleted

We also have to update the Flash and Silverlight files others the player would be broken in IE8.

#6 @ocean90
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 37887:

External Libraries: Update MediaElement.js to 2.21.2.

Includes a fix for broken YouTube embeds in Firefox.

Changelog: https://github.com/johndyer/mediaelement/blob/2.21.1/changelog.md
Diff: https://github.com/johndyer/mediaelement/compare/2.18.1...2.21.1

Props swissspidy.
Fixes #36759.

#7 @ocean90
3 years ago

#37229 was marked as a duplicate.

#8 @sakibmoon
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

For me youtube share link works, but the full URL do not

[video src="https://www.youtube.com/watch?v=mhnuES3Zgr4"] do not work for me but [video src="https://youtu.be/mhnuES3Zgr4"] works. Note that both of them are same url.

Last edited 3 years ago by sakibmoon (previous) (diff)

#9 @flyplugins
3 years ago

I just tested with version 38002 an it worked as expected for both Chrome and FireFox. As @sakibmoon mentioned, you must use the "share URL":

[video src="https://youtu.be/57MKxz4pJKE"]

#10 @ocean90
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

@flyplugins, @sakibmoon: Created a new ticket for this: #37363.

Note: See TracTickets for help on using tickets.