WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#36781 closed defect (bug) (fixed)

Link toolbar sometimes disappears and can't reopen

Reported by: ericlewis Owned by: azaozz
Milestone: 4.6 Priority: normal
Severity: normal Version: 4.5
Component: Editor Keywords:
Focuses: javascript Cc:

Description

When clicking on the link dialog, then pressing escape, sometimes internal state seems to get tied up. The link button will still be highlighted, and clicking it or the keyboard shortcut (Command+K on Mac) will not reopen the link dialog. Moving the text caret fixes it.

Can reproduce by clicking around in the content and opening link dialog / pressing escape repeatedly.

Attachments (3)

36781.mp4 (279.0 KB) - added by ericlewis 4 years ago.
36781.diff (2.0 KB) - added by azaozz 4 years ago.
36781.1.diff (2.2 KB) - added by azaozz 4 years ago.

Download all attachments as: .zip

Change History (7)

@ericlewis
4 years ago

#1 @ericlewis
4 years ago

See attachment:36781.mp4 for a screencast.

@azaozz
4 years ago

#2 @azaozz
4 years ago

  • Milestone changed from Awaiting Review to 4.6

In 36781.diff: properly reset the state of the inline link toolbar on escape, unlink and clicking elsewhere in the editor.

#3 @azaozz
4 years ago

Related #36732 and #37153.

@azaozz
4 years ago

#4 @azaozz
4 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 37906:

TinyMCE, inline link dialog:

  • Reset the internal state when doing unlink, pressing Escape, and clicking elsewhere in the editor.
  • Add the unlink shortcut from the wplink plugin as it triggers the new wp_unlink command.

Fixes #36781, #36732, #37153.

Note: See TracTickets for help on using tickets.