Context Navigation

← Previous Ticket
Next Ticket →

#36783 closed defect (bug) (fixed)

wplink should prioritize textContent over innerText so as to ignore any text-transform styling

Reported by:	dougwollison	Owned by:	azaozz
Priority:	normal	Milestone:	4.6
Component:	Editor	Version:
Severity:	normal	Keywords:
Cc:		Focuses:	ui, javascript

Description

On numerous sites we add button styles that use all-caps text. For SEO purposes, we don't literally make the text all-caps and have CSS ensure it's that way via text-transform.

However, in wplink, the text content of the link will be pulled in all-caps form when editing the link. This is due to this line in wp-includes/js/wplink.js:

linkText = linkNode.innerText || linkNode.textContent;

Based on how the tinyMCE plugin works, it should be safe to swap those priorities around:

linkText = linkNode.textContent || linkNode.innerText;

I've done a quick test on a site and it pulls the real, untransformed text; though I'd imagine it needs further testing; but I'm pretty sure old IE will fallback properly to innerText, which if I'm not mistaken is handled like the new textContent would.

Attachments (1)

36783.diff (507 bytes ) - added by dougwollison 10 years ago.: Reorders priority for linkText assignment

Download all attachments as: .zip

Change History (4)

@dougwollison
10 years ago

Attachment 36783.diff added

Reorders priority for linkText assignment

#1 @azaozz
10 years ago

Milestone Awaiting Review → 4.6

Makes sense.

#2 @azaozz
10 years ago

Owner set to azaozz
Resolution → fixed
Status new → closed

In 37621:

Editor wpLink: swap the order of innerText and textContent to avoid getting styled text in IE.

Props dougwollison.
Fixes #36783.

#3 @iseulde
10 years ago

Version trunk

Maybe it's worth adding a comment for the future?

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core