Opened 7 years ago
Closed 7 years ago
#36796 closed enhancement (fixed)
Link "widget areas" to widgets panel in menu locations section description
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | normal | Version: | 4.3 |
Component: | Customize | Keywords: | has-patch has-screenshots commit |
Focuses: | ui | Cc: |
Description
In the menus panel description, the text "widget areas" is linked to the widgets panel and conditional on the theme supporting widgets. This should also be the case for the menu locations section description. The text is currently incorrectly displayed for themes that don't support widgets.
This would be a good opportunity to use the new focusConstructAndReturnToControlWhenCollapsed
function introduced in #32683, although this is tied to a section, not a control, so perhaps it should be generalized to focusConstructAndReturnWhenCollapsed
and added to sections and panels as well. Let's finalize that on #32683, then revisit here.
Attachments (2)
Change History (17)
#2
@
7 years ago
Ends up causing
Parse error: syntax error, unexpected 'public' (T_PUBLIC) in /srv/www/wordpress-trunk/wp-includes/class-wp-customize-nav-menus.php on line 639
#3
@
7 years ago
@lukecavanagh are you sure the patch applied correctly? public
doesn't appear in the patch, although maybe there's a missing semicolon or something?
#4
@
7 years ago
@celloexpressions I will clean up my local WP and apply the patch again, just to check.
#5
@
7 years ago
@celloexpressions patch applied fine, without any errors and customizer loads fine. This was using TwentySixteen as the active theme on the local dev site.
This ticket was mentioned in Slack in #core by chriscct7. View the logs.
7 years ago
#10
@
7 years ago
Just tested the patch and it works fine for me.
OS: Windows 10
Browser: Chrome 50.0.2661.102 , Safari 5.1.7 , IE-11 , Firefox 46.0.1
WP 4.5.2 , 4.5.3-alpha-37528
Server Environment : VVV
This ticket was mentioned in Slack in #core by voldemortensen. View the logs.
7 years ago
#12
@
7 years ago
- Keywords commit added; needs-testing removed
- Owner changed from celloexpressions to westonruter
- Status changed from assigned to reviewing
Ready for final review.
Actually, I don't think it's necessary to keep a breadcrumb here, so 36796.diff should work (and matches what the panel does).