wp_normalize_path in plugin_dir_path

[sebastian.pisula]

I suggest use wp_normalize_path in plugin_dir_path

[ocean90]

@sebastian.pisula Can you explain why this would be needed?

[sebastian.pisula]

I use Windows and XAMPP. For code

<?php
var_dump( plugin_dir_path( __FILE__ ));

I have
string(55) "D:\xampp\htdocs\wordpress\wp-content\plugins\my-plugin/"

but should be

string(55) "D:/xampp/htdocs/wordpress/wp-content/plugins/my-plugin/"

[dd32]

What's the expectation for having it using /?

I actually support adding it, although actually feel the existing result is the intended result, it's what's contained within ABSPATH and works perfectly fine on a windows system.

We don't really change/add things for the sake of adding it though, having a reason for why you expect it one way or another makes things much more valid.

[hellofromTonya]

Related: #15598, #16457, #17494, #20849, #28811, #48099

[hellofromTonya]

Hello @sebastianpisula,

Thank you for the patch!

Though it looks odd, Windows recognizes both types of slashes and even mixed combinations of the slashes.

I'm closing this ticket as wontfix. Why?

Slashes has been discussed in multiple tickets. As it works, there hasn't yet been a compelling reason to change it.

As @ jrf comments on Ticket 48099:

This is working perfectly fine. The fact that it looks strange is irrelevant.

Thank you again for the patch!