WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#36833 closed defect (bug) (fixed)

The username input in registration form (multisite) should have autocapitalize set to "none"

Reported by: christinecooper Owned by: jeremyfelt
Milestone: 4.6 Priority: normal
Severity: normal Version: 4.5.2
Component: Login and Registration Keywords: has-patch commit
Focuses: ui, template, multisite Cc:
PR Number:

Description

When a user creates an account on a multisite network environment using iOS, it will automatically transform the first letter into capital.

And once the user clicks the register button, they are greeted with the lovely message of "your username cannot contain capital letters".

This can be addressed easily by adding

autocapitalize="none"

to the input field.

I would also suggest adding autocorrect="off"... Read more here: http://stackoverflow.com/questions/6356074/iphone-browser-defaulting-to-uppercase-for-first-letter-of-password-fields

You should add this attribute to all input fields essentially.

Attachments (1)

36833.diff (666 bytes) - added by rafaelangeline 3 years ago.
Set autocapitalize none to use name field in registration form (multisite)

Download all attachments as: .zip

Change History (10)

#1 @iamfriendly
3 years ago

  • Component changed from General to Login and Registration
  • Focuses ui added

I'm going to preface this with: I'd support this inclusion.

I need to bring up the browser/platform support. autocapitalize was created by apple - for iOS5. It is not part of the official HTML spec. This means it will fail any validation. It's supported in Safari (since ios5) and on google Chrome (since v 43) on both Android and iOS.

The 'official' way to do this would be with inputmode but sadly, that received very little interest from browser vendors. It's only on Firefox OS (prefixed)

Here's the official proposal for autocapitalize : https://github.com/mounirlamouri/html-autocapitalize/blob/master/proposal.md

#2 @jeremyfelt
3 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 4.6

+1 We're okay to add autocapitalize and autocorrect for inputs like these due to the popularity of the browsers that use them. Previously #32646 and #32644.

#3 follow-up: @christinecooper
3 years ago

Wait a minute, are you telling me that there are 2 other tickets with this issue, and this is yet to be implemented to core?

Who's making decisions nowadays??

#4 in reply to: ↑ 3 @knutsp
3 years ago

Replying to christinecooper:

Wait a minute, are you telling me that there are 2 other tickets with this issue, and this is yet to be implemented to core?

As you should see, those previous tickets was closed as fixed.

Who's making decisions nowadays??

Browser makers never learn and still pollute the web with non-standard things.

@rafaelangeline
3 years ago

Set autocapitalize none to use name field in registration form (multisite)

#5 @rafaelangeline
3 years ago

  • Keywords has-patch added; needs-patch removed

Just added a patch to this ticket...

#6 @boonebgorges
3 years ago

  • Keywords commit added; good-first-bug removed
  • Owner set to jeremyfelt
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core by rafaelangeline. View the logs.


3 years ago

#8 @jeremyfelt
3 years ago

  • Status changed from assigned to reviewing

Looks good, thanks for the patch @rafaelangeline!

#9 @jeremyfelt
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 37546:

Multisite: Disable autocapitalize and autocorrect for user_name input on signup

Props rafaelangeline.
Fixes #36833.

Note: See TracTickets for help on using tickets.