WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 8 weeks ago

#36854 reopened enhancement

Fix for comment reply button focus on button elements in js

Reported by: MarcDK Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.6
Component: Comments Keywords: bulk-reopened
Focuses: javascript Cc:

Description

Some users use themes or plugins which put button form elements before the textarea element in the comment form. The comment-reply.js assumes that there are no button elements. I added a check if the element type is "button". In that case the selection is skipped which results in the correct behaviour: the focus is set on the textarea element. Not on buttons like "bold", "italic" and so on.

I included a minified version of the comment-reply.js file. I did not know if this was necessary.

Attachments (1)

fix_button_focus_on_reply.patch (3.5 KB) - added by MarcDK 3 years ago.

Download all attachments as: .zip

Change History (3)

#1 @iseulde
4 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

This ticket has not seen any activity in over *two* years, so I'm closing it as "wontfix".

The ticket may lack decisiveness, may have become irrelevant, or may not have gathered enough interest.

If you think this ticket does deserve some attention again, feel free to reopen.

For bugs, it would be great if you could provide updated steps to reproduce against the latest version of WordPress (5.0.2 at the time of writing). Remember images or a video can be superior to explain a problem. At the very least, quickly test again to make sure the bug still exists.

If it’s an enhancement or feature, some extra motivation may help.

Thank you for your contributions to WordPress! <3

#2 @JeffPaul
8 weeks ago

  • Keywords bulk-reopened added
  • Milestone set to Awaiting Review
  • Resolution wontfix deleted
  • Status changed from closed to reopened

A decision was made to reopen tickets that were closed in the bulk edit that this ticket was affected by. This ticket is being placed back into the Awaiting Review milestone so it can be individually evaluated and verified to determine if it is still relevant/valid or reproducible.

Note: See TracTickets for help on using tickets.