Use .notice-alt for nav menu error message

[ocean90]

See [34365] and attached screenshot.

The message gets triggered when the post type of a menu entry doesn't exist anymore.

[barryceelen]

Simply adding the .notice-alt class did not do the trick as the class was (not yet) meant to be added to error or success divs. Adapted the stylesheets to allow for this.

[ocean90]

@barryceelen Thanks for the patch. You can replace existing classes with the new ones. Have you tried adding notice, notice-alt and notice-error?

[barryceelen]

@ocean90 Sorry I was unclear: I modified the common.css and common-rtl.css files so we can now use the notice-alt classes on div.error and div.success.

[ocean90]

@barryceelen Yep, but we don't have to change that. We can use the new classes instead.

You don't have to patch RTL files, they are generated by our build tools. For patches you should use ​https://develop.svn.wordpress.org. The repo contains only the source files.

[barryceelen]

@ocean90 Okay, I see what you mean :-)
New patch added.

[ocean90]

@barryceelen The change looks correct, but the diff is inverted. :)

I think we should use .notice-info for the $some_pending_menu_items case, see attached screenshots.

[barryceelen]

Uh oh. <note-to-self>No trac tickets on sundays.</note-to-self>
Anyway, using .notice-info is best indeed.

[ocean90]

In 37529:

Menus: Use new colors for error/info notices.

Props barryceelen.
Fixes #36857.