Opened 9 years ago
Closed 9 years ago
#36857 closed defect (bug) (fixed)
Use .notice-alt for nav menu error message
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Menus | Keywords: | good-first-bug has-patch |
Focuses: | ui, administration | Cc: |
Description
See [34365] and attached screenshot.
The message gets triggered when the post type of a menu entry doesn't exist anymore.
Attachments (7)
Change History (15)
#2
@
9 years ago
- Owner set to barryceelen
- Status changed from new to assigned
@barryceelen Thanks for the patch. You can replace existing classes with the new ones. Have you tried adding notice
, notice-alt
and notice-error
?
#3
@
9 years ago
@ocean90 Sorry I was unclear: I modified the common.css and common-rtl.css files so we can now use the notice-alt
classes on div.error
and div.success
.
#4
@
9 years ago
@barryceelen Yep, but we don't have to change that. We can use the new classes instead.
You don't have to patch RTL files, they are generated by our build tools. For patches you should use https://develop.svn.wordpress.org. The repo contains only the source files.
#6
@
9 years ago
- Focuses administration added
- Keywords needs-refresh added
- Milestone changed from Future Release to 4.6
@barryceelen The change looks correct, but the diff is inverted. :)
I think we should use .notice-info
for the $some_pending_menu_items
case, see attached screenshots.
Simply adding the .notice-alt class did not do the trick as the class was (not yet) meant to be added to error or success divs. Adapted the stylesheets to allow for this.