WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#36857 closed defect (bug) (fixed)

Use .notice-alt for nav menu error message

Reported by: ocean90 Owned by: barryceelen
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: Menus Keywords: good-first-bug has-patch
Focuses: ui, administration Cc:
PR Number:

Description

See [34365] and attached screenshot.

The message gets triggered when the post type of a menu entry doesn't exist anymore.

Attachments (7)

36857.png (107.7 KB) - added by ocean90 3 years ago.
36857.diff (2.4 KB) - added by barryceelen 3 years ago.
36857.1.diff (1.1 KB) - added by barryceelen 3 years ago.
36857-success.png (70.8 KB) - added by ocean90 3 years ago.
36857-info.png (76.5 KB) - added by ocean90 3 years ago.
36857-warning.png (72.8 KB) - added by ocean90 3 years ago.
36857.2.diff (1.0 KB) - added by barryceelen 3 years ago.

Download all attachments as: .zip

Change History (15)

@ocean90
3 years ago

@barryceelen
3 years ago

#1 @barryceelen
3 years ago

  • Keywords has-patch added; needs-patch removed

Simply adding the .notice-alt class did not do the trick as the class was (not yet) meant to be added to error or success divs. Adapted the stylesheets to allow for this.

#2 @ocean90
3 years ago

  • Owner set to barryceelen
  • Status changed from new to assigned

@barryceelen Thanks for the patch. You can replace existing classes with the new ones. Have you tried adding notice, notice-alt and notice-error?

#3 @barryceelen
3 years ago

@ocean90 Sorry I was unclear: I modified the common.css and common-rtl.css files so we can now use the notice-alt classes on div.error and div.success.

#4 @ocean90
3 years ago

@barryceelen Yep, but we don't have to change that. We can use the new classes instead.

You don't have to patch RTL files, they are generated by our build tools. For patches you should use https://develop.svn.wordpress.org. The repo contains only the source files.

@barryceelen
3 years ago

#5 @barryceelen
3 years ago

@ocean90 Okay, I see what you mean :-)
New patch added.

@ocean90
3 years ago

@ocean90
3 years ago

@ocean90
3 years ago

#6 @ocean90
3 years ago

  • Focuses administration added
  • Keywords needs-refresh added
  • Milestone changed from Future Release to 4.6

@barryceelen The change looks correct, but the diff is inverted. :)

I think we should use .notice-info for the $some_pending_menu_items case, see attached screenshots.

@barryceelen
3 years ago

#7 @barryceelen
3 years ago

  • Keywords needs-refresh removed

Uh oh. <note-to-self>No trac tickets on sundays.</note-to-self>
Anyway, using .notice-info is best indeed.

Last edited 3 years ago by barryceelen (previous) (diff)

#8 @ocean90
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 37529:

Menus: Use new colors for error/info notices.

Props barryceelen.
Fixes #36857.

Note: See TracTickets for help on using tickets.