WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#36863 closed defect (bug) (fixed)

Editor Help dialog shortcut on different platforms and the iframe title

Reported by: afercia Owned by: azaozz
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: has-patch has-screenshots
Focuses: accessibility, javascript Cc:
PR Number:

Description

When entering the Editor, screen readers announce the title attribute set on the Editor iframe. Iframes must always have a title attribute to give context to users. By the way, the current title text is always the same, regardless of the platform:

Rich Text Area. Press Alt-Shift-H for help

While Alt-Shift-H perfectly works on Windows, on a Mac the keyboard shortcut is different and it's Control-Alt-H. Mac and VoiceOver users will still ear "Alt-Shift-H" though.

It would be great to use a different iframe title attribute depending on the used platform. Maybe also changing it on the fly with JavaScript could work (would need some testing).

Attachments (1)

36863.diff (2.2 KB) - added by afercia 4 years ago.

Download all attachments as: .zip

Change History (4)

@afercia
4 years ago

#1 @afercia
4 years ago

  • Focuses javascript added
  • Keywords has-patch has-screenshots added
  • Milestone changed from Awaiting Review to Future Release

36863.diff is a first pass, uses tinymce.Env.mac which is the same check used the keyboard shortcuts help dialog. Screenshot on Safari+VoiceOver:

https://cldup.com/z0IyMaJTkh.png

#2 @azaozz
4 years ago

  • Component changed from Editor to TinyMCE
  • Milestone changed from Future Release to 4.6

Patch looks good, lets fix this :)

There is already preInit callback in there, no need for another. Also there is editor.iframeElement now.

#3 @azaozz
4 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 38110:

TinyMCE: replace the editor iframe title on MacOS to fix the help shortcut.

Props afercia, azaozz.
Fixes #36863.

Note: See TracTickets for help on using tickets.