WordPress.org

Make WordPress Core

Opened 15 months ago

Closed 3 months ago

#36868 closed defect (bug) (duplicate)

Custom Logo with alternative text

Reported by: taijacg Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Customize Keywords:
Focuses: accessibility, javascript Cc:

Description

When experimenting with the new Theme Logo system in 4.5, I noticed the following a11y issue:

Steps to reproduce:

  1. In customizer, upload logo under Site Identity
  2. Add alternative text to logo in upload interface
  3. Follow on screen process to crop image

Result:
Cropped image does not inherit alternative text from original, and an option to add new alternative text is not provided as part of the workflow. As a result, the image file name is very likely to end up as the alternative text for the site logo.

Expected:

  • Alternative text to be copied automatically to the cropped image OR
  • an opportunity be given for users to add new alt text to the cropped image AND / OR
  • site identity information (site title/etc) be used as alt text if none is provided

There is also no easy way provided to filter the logo alt text, or fetch only the image, so that this issue can be worked around at the theme level.

Thank you!

Change History (6)

#1 in reply to: ↑ description @joshue108
14 months ago

Hi,

Thanks for this - I'm seeing this bug without actually cropping the image.
It may be related to the theme, but I doubt it as there are plenty if images that have the correct @alt text associated. This bug was pointed out to me and they seem related.
The @alt text is added to the image/logo in the Media Library - I don't recall cropping the image at all (but may have).

HTH

Josh

Replying to taijacg:

When experimenting with the new Theme Logo system in 4.5, I noticed the following a11y issue:

Steps to reproduce:

  1. In customizer, upload logo under Site Identity
  2. Add alternative text to logo in upload interface
  3. Follow on screen process to crop image

Result:
Cropped image does not inherit alternative text from original, and an option to add new alternative text is not provided as part of the workflow. As a result, the image file name is very likely to end up as the alternative text for the site logo.

Expected:

  • Alternative text to be copied automatically to the cropped image OR
  • an opportunity be given for users to add new alt text to the cropped image AND / OR
  • site identity information (site title/etc) be used as alt text if none is provided

There is also no easy way provided to filter the logo alt text, or fetch only the image, so that this issue can be worked around at the theme level.

Thank you!

#3 @joemcgill
13 months ago

  • Component changed from General to Customize
  • Focuses javascript added

#4 @afercia
13 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Version changed from 4.5.2 to 4.5

#5 @afercia
3 months ago

  • Keywords close added; needs-patch removed

Quick update: [38812] removed the fallback to the filename. Also, #38768 is going to provide the site name as fallback for the custom logo alt attribute. The issue with cropped images happen with any image and is tracked in #37750. Therefore, this ticket can probably be closed. Any thoughts welcome.

#6 @afercia
3 months ago

  • Keywords close removed
  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from new to closed
  • Version 4.5 deleted

Closing in favor of #37750, that's more specific to the cropping issue.

Note: See TracTickets for help on using tickets.