No Action For Manually Updated Translations

[ronalfy]

Right now, core, theme, and plugin have the do_action of upgrader_process_complete applied to them.

I feel this should also be applied for manual updates of translations.

[ronalfy]

I'd be willing to go ahead with a patch on this pending the ownership of a core contributor or blessed by the component maintainer.

[ronalfy]

New Action for Tracking Manual Language Updates

[ronalfy]

I went ahead with a new action language_updates_complete since it didn't fall in the scheme of upgrader_process_complete.

Use-case is for logging translations.

[ronalfy]

Example output.

<?php
Marker - May 31, 2016, 5:45:18 PM
[31-May-2016 22:45:21 UTC] Array
(
    [0] => Array
        (
            [language] => de_DE
            [version] => 4.5.2
            [type] => core
            [slug] => default
        )

)

[31-May-2016 22:45:40 UTC] Array
(
    [0] => Array
        (
            [language] => de_DE
            [version] => 3.1.5
            [type] => plugin
            [slug] => akismet
        )

    [1] => Array
        (
            [language] => de_DE
            [version] => 2.2.1
            [type] => plugin
            [slug] => cmb2
        )

    [2] => Array
        (
            [language] => de_DE
            [version] => 6.0.5
            [type] => plugin
            [slug] => stops-core-theme-and-plugin-updates
        )

    [3] => Array
        (
            [language] => de_DE
            [version] => 2.2.2
            [type] => plugin
            [slug] => metronet-reorder-posts
        )

    [4] => Array
        (
            [language] => de_DE
            [version] => 1.4
            [type] => theme
            [slug] => twentyfifteen
        )

    [5] => Array
        (
            [language] => de_DE
            [version] => 1.6
            [type] => theme
            [slug] => twentyfourteen
        )

    [6] => Array
        (
            [language] => de_DE
            [version] => 1.7
            [type] => theme
            [slug] => twentythirteen
        )

)

[ronalfy]

Fix formatting issues

[ronalfy]

Typo fix of array to string

[DrewAPicture]

Replying to slackbot:

This ticket was mentioned in ​Slack in #core by ronaldhuereca. ​View the logs.

See the linked Slack discussion about possible just reusing the upgrader_process_complete for language pack updates.

[DrewAPicture]

I was mistaken, @ronalfy is talking about wanting to log all language packs being updated rather than individually. The reuse of upgrader_process_complete for language packs, however, wouldn't be a terrible idea for another ticket.

[DrewAPicture]

Yay, milestone gymanstics.

[ronalfy]

Using filter for plugins, themes, core.

[ronalfy]

Adding documentation

[ronalfy]

Action for tracking manual updates of translations

[ronalfy]

Ended up going with upgrader_process_complete thanks to the help of @DrewAPicture.

[ocean90]

There are a few version checks hooked into upgrader_process_complete see trunk/src/wp-admin/includes/admin-filters.php?rev=37570&marks=110-114#L110​. I think these should be removed in Language_Pack_Upgrader::bulk_upgrade().

[ronalfy]

Action for tracking manual updates of translations

[ronalfy]

Thanks for the feedback @ocean90 . Patch updated and I also resolved a PHP warning error when the language is changed from the settings panel.

[ocean90]

36872.7.patch​ looks good. In 36872.8.patch​ I tweaked the docs a bit and restored the version checks after the upgrader_process_complete hook.

@DrewAPicture Are you happy with the docs?

[DrewAPicture]

@ocean90 The docs look great :)

[ocean90]

In 37687:

Upgrade: Trigger the upgrader_process_complete action for translation updates.

This brings Language_Pack_Upgrader in line with the core, theme, and plugin upgrader.

Props ronalfy.
Fixes #36872.