WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#36880 closed defect (bug) (fixed)

Correct @link in /wp-includes/cache.php

Reported by: michaelbeil Owned by: DrewAPicture
Priority: normal Milestone: 4.6
Component: Cache API Version: 2.6
Severity: normal Keywords: has-patch
Cc: Focuses: docs

Description

The @link in the Object Cache API DocBlock is ​https://codex.wordpress.org/Function_Reference/WP_Cache and it should be ​https://codex.wordpress.org/Function_Reference/WP_Object_Cache.

Introduced in [7990].

Attachments (2)

36880.diff​ (395 bytes ) - added by michaelbeil 10 years ago.
36880.2.diff​ (392 bytes ) - added by michaelbeil 10 years ago.

Download all attachments as: .zip

Change History (7)

@michaelbeil
10 years ago

#1 @swissspidy
10 years ago

I assume you mean https://codex.wordpress.org/Class_Reference/WP_Object_Cache? :)

The problem is that the file doesn't just contain the class, but also the helper methods. We should really split this up.

After that, the docblock can be adjusted accordingly.

@michaelbeil
10 years ago

#2 @michaelbeil
10 years ago

Yea, @swissspidy, that is exactly what I meant :). I updated the diff accordingly.

What would be the best way of splitting this up?

WP_Object_Cache is both not a function and not WP_Cache.

#3 @DrewAPicture
10 years ago

  • Focuses docs added
  • Keywords has-patch added
  • Milestone Awaiting Review → 4.6
  • Owner set to DrewAPicture
  • Status new → reviewing

#4 @DrewAPicture
10 years ago

In 37460:

Docs: Fix an incorrect Codex link in the file header for wp-includes/cache.php.

Introduced in [7990].

Props michaelbeil.
See #36880.

#5 @DrewAPicture
10 years ago

  • Resolution → fixed
  • Status reviewing → closed

@swissspidy Let's close this as fixed for the single issue.

I'd venture to guess that the reason why we've left cache.php alone is that it can still be directly preempted by an object-cache.php drop-in.

Note: See TracTickets for help on using tickets.