Add caching to get_page_by_title

[spacedmonkey]

Add caching to get_page_by_title so it doesn't call the posts table.

[spacedmonkey]

Related: #36711

[boonebgorges]

Change seems OK, but get_page_by_title() has no automated test coverage at all. We'll need basic tests to introduce this kind of change.

[boonebgorges]

Previously: #15805.

[igmoweb]

get_page_by_title() using WP_Query

[igmoweb]

Unit tests for 36905.2.patch

[igmoweb]

I propose to let WP_Query handle this.

I'd also propose to deprecate this function. Is not used by Core so plugins could use their own functions instead. Querying by title is not a very good idea so we would be discouraging developers to use this function (maybe just a little but more than nothing). @scribu said the same in here: https://core.trac.wordpress.org/ticket/20350#comment:1 I don't know if she would think the same today.

Anyway, here are my changes: Unit tests + changes inside the function (not deprecated though) so now it uses WP_Query instead.

[DrewAPicture]

Assigning to mark the good-first-bug as "claimed".

@igmoweb Can you please combine 36905.2.patch​ and 36905.2.tests.patch​ into a single patch?

[igmoweb]

Changes + Unit tests

[igmoweb]

Done.

Do we now upload changes + tests in the same file? I thought it was the other way.

[dd32]

Do we now upload changes + tests in the same file? I thought it was the other way.

We used to do it separately as they were in two different repo's, they're now combined so doing it in one patch is easier to keep track of everything (especially when things start getting into multiple iterations)

[igmoweb]

Some improvements + some more unit tests

[igmoweb]

patch 4 was mixed up with another ticket changes

[igmoweb]

36905.5.patch includes some improvements to the function:

• orderby is set to 'none' so it preserves the same order than the original function
• post_status is now an array with 'any' + all existent statuses even those that are excluded from search. This way, the query has less conditionals in WHERE clause and post_status field is not even filtered, like the original function.
• I added tests to check that the function query every single post status.

[pcfreak30]

patch refresh

[pcfreak30]

patch refresh

[pcfreak30]

Added a refresh based on current trunk. A duplicate copy was added due to internet issues :P. Refresh has not been tested, but mainly fixed to apply properly, and explicitly return null.

[spacedmonkey]

@igmoweb @pcfreak30 Looking at your patches, I have one simple question, how does this fix the issue? Using WP_Query is nice, but WP_Query isn't have any query caching out of the box. Even if are you using ​advanced-post-cache or ​enhanced-post-cache neither of which, cache queries with 'fields' => 'ids' set.

See that #36711 is basically the same code and @boonebgorges merged that. We should go back to my original patch. This will likely need a refresh after all coding standards changes.

[pcfreak30]

@spacedmonkey your patch looks nice however wp_query does cache with 'cache_results' if wp_using_ext_object_cache() is true, so the extra cache check in your version is unneeded. Even with it, it only helps if doing memory caching, which is up for debate if the extra complexity matters vs using core wp_query.

Also, I generally feel direct DB access for stuff like this should be avoided overall. We have a query system, it should be used if possible.

[spacedmonkey]

@pcfreak30 Sadly, you are incorrect, with the cache_results flag set, all that does is prime post caches and the query it's self is not cached. See ​this and the related ticket #22176 .

However, I do agree, we should be using WP_Query, as it is clearer that way. I will update the patch to fix the caching in with the query call changes.

[desrosj]

#46439 was marked as a duplicate.

[spacedmonkey]

@igmoweb Are you willing to work on this patch still? I am willing to pick it up otherwise.

[igmoweb]

@spacedmonkey Feel free to take it again, thanks :)

refresh and tests
Tests not working

Trac ticket: https://core.trac.wordpress.org/ticket/36905

Trac ticket: https://core.trac.wordpress.org/ticket/36905

[spacedmonkey]

Now the WP_Query is cached, let's just use WP_Query in this function.

Closing in favour of ​https://github.com/WordPress/wordpress-develop/pull/3236

CC @pbearne.

[peterwilsoncc]

Commit ready as of 88bee5302227b0a27e8f2a0d8b2691b509c065a2 on the ​linked pull request.

[peterwilsoncc]

In 54234:

Posts, Post types: Cache get_page_by_title().

Convert get_page_by_title() to a WP_Query wrapper to take advantage of the object caching built in to the latter.

Add dedicated unit tests for the function get_page_by_title().

Props spacedmonkey, boonebgorges, igmoweb, pcfreak30, pbearne.
Fixes #36905.

Merged in https://core.trac.wordpress.org/changeset/54234 / 7ad9e7d

https://core.trac.wordpress.org/ticket/36905

cc @costdev

[peterwilsoncc]

In 54242:

Posts, Post types: Coding standards fixes following [54234].

Props costdev.
See #36905.

Merged https://core.trac.wordpress.org/changeset/54242 / f450acf7afdce2859d5ede3656626ca5538b592b

[peterwilsoncc]

In 54271:

Posts, Post Types: Fix WP_Query parameter used by get_page_by_title().

Fixes the call to WP_Query within get_page_by_title() by using the correct title parameter, title.

Modify the orderby parameter to prioritize the oldest published date over the smallest post ID. This ensures the behaviour matches that of the previous version of get_page_by_title().

The tests have been modified to include a populated post table to ensure the posts returned are matched by design rather than coincidence.

Follow up to [54234].

Props dd32, timothyblynjacobs, peterwilsoncc.
Fixes #56609.
See #36905.

[spacedmonkey]

Made a start of dev notes ​here.

[milana_cap]

Dev note: ​https://make.wordpress.org/core/2022/10/07/improvements-to-wp_query-performance-in-6-1/