WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #36908, comment 6


Ignore:
Timestamp:
08/29/2016 11:07:35 PM (4 years ago)
Author:
ryankienstra
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #36908, comment 6

    initial v1  
    66* [https://github.com/xwp/wordpress-develop/pull/153/commits/9d9ffa54825e738d3a144b14c520b77328696978 Commit 9d9ffa54] : Create [https://github.com/xwp/wordpress-develop/compare/trac-36908?expand=1#diff-49c6fb18cfad3f9946aa8ca15b809b3fR770 search icon] in `<input>`, using neighbor `<div>` with [https://github.com/xwp/wordpress-develop/compare/trac-36908?expand=1#diff-6bdd5041777c50e624f1d0beae2e0b7cR1453 :after]. It's not possible to set this as a `:before` or `:after` psuedo-element of the `<input>`. [https://github.com/xwp/wordpress-develop/compare/trac-36908?expand=1#diff-6bdd5041777c50e624f1d0beae2e0b7cR1425 Increase padding-left] from `10px` to `30px` to create space for this. Mainly copy styling of `.clear-results` in [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/customize-nav-menus.css#L626 customize-nav-menus.css#L626]. In menu search field, [https://github.com/xwp/wordpress-develop/compare/trac-36908?expand=1#diff-79f9bc58f474eba515dbb6e2822b7a22R628 increase clickable area] of x icon.
    77
    8 One open question is whether the "widgets search field" should have the "same custom control" (red "x" button) So far, this only appears in the [https://cloudup.com/cFRQ_Zxg8QZ menu search field].
     8One open question is whether the "widgets search field" should have the "same custom control" (red "x" button). So far, this only appears in the [https://cloudup.com/cFRQ_Zxg8QZ menu search field].
    99
    1010This ticket's description states: