[4798] breaks some option usage scenarios including permalinks.

[westi]

[4798] Breaks the page permalinks on my test blog.

When you update the permalinks on option-permalinks the following happens:

1. delete_option is called for 'page_uris'.
2. update_option is called for 'page_uris'.
3. This calls into get_option which marks the option as non-existent
4. Then this calls add_option (as the option didn't exist) which adds the option to the db
5. Then update_option returns.

Patch to fix attached
This means we have the option in the db (and cache) but we also have cached that the option doesn't exist.

get_option listens to the notoption cache above all else so we can no longer access the option!

[westi]

Fixup add_option to clear the notoption cache

[Makki]

This resolved my problem with permalinks. thank you

[westi]

Replying to Makki:

This resolved my problem with permalinks. thank you

I assume you are referring to #3686?

This issue only affects trunk (2.2-bleeding) and not 2.1 you really shouldn't be running your blog on 2.2-bleeding.

[markjaquith]

(In [4820]) Have add_option() for options whose non-existence has been cached clear that cached non-existence before adding the option. Nice catch by Westi. fixes #3692

[ryan]

(In [4831]) Remove notoptions caching. Multile rewrite_rules options were being created. See #3692 #2268