WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #36926, comment 1


Ignore:
Timestamp:
05/24/2016 04:36:23 AM (3 years ago)
Author:
rmccue
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #36926, comment 1

    initial v1  
    11Added an actual patch for core; renamed from `$spl_autoloaders` to `$_wp_spl_autoloaders` to indicate that a) it's part of a shim and shouldn't be used, and b) to avoid any potential variable conflicts. While we could introduce a class with protected/private vars to actually protect it, that's too much overhead for just a shim, especially one that's only loaded on a small number of installs.
    22
    3 This doesn't really introduce any new stuff into core, apart from the compatibility shim for 5.2, so it should be pretty uncontroversial. Core ''does'' actually use this with the introduction of Requests, plus we can remove the check in the SimplePie loader (see [attachment:36926.2.diff]. Based on this, I'd like to get it into core this cycle, regardless of progress on #36335 (although I hope we can get that in too!).
     3This doesn't really introduce any new stuff into core, apart from the compatibility shim for 5.2, so it should be pretty uncontroversial. Core ''does'' actually use this with the introduction of Requests, plus we can remove the check in the SimplePie loader (see [attachment:36926.2.diff]). Based on this, I'd like to get it into core this cycle, regardless of progress on #36335 (although I hope we can get that in too!).