Opened 8 years ago
Closed 8 years ago
#36991 closed defect (bug) (fixed)
Page numbers are inconsistent when manually deleting comments
Reported by: | samuelsidler | Owned by: | rachelbaker |
---|---|---|---|
Milestone: | 4.6 | Priority: | low |
Severity: | minor | Version: | |
Component: | Comments | Keywords: | has-patch |
Focuses: | administration | Cc: |
Description
STR:
- Have a lot of pages of comments/pings.
- Filter on only one of them (like pings) and more than one page of them.
- Go to the last page of pings and delete all pings on the page manually (not bulk delete).
- The number of pages changes, as expected, but changes from e.g. 6/6 to the total number of pages across both comment types (e.g. 6/41).
Per @rachelbaker, introduced in [17354].
Attachments (1)
Change History (6)
This ticket was mentioned in Slack in #core-comments by sam. View the logs.
8 years ago
#3
@
8 years ago
This occurs when filtering the Comments list table by a particular comment_type, because wp_count_comments()
doesn't account for different comment_types. In type_list_pagination.patch, if the comment_type
query var is set, I fallback to the $total - 1
value.
Note: See
TracTickets for help on using
tickets.
Don't use wp_count_comments if filtering by comment_type