Changes between Initial Version and Version 1 of Ticket #36995, comment 18
- Timestamp:
- 07/08/2018 03:55:45 PM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #36995, comment 18
initial v1 1 1 I realized that the ability to register arbitrary path scopes for a given service worker script may needlessly complicating the implementation. On further reflection, it seems a script should only ever be registered for the frontend (scope `/`) and the admin (scope `/wp-admin/`). The frontend scope would by default include the admin, unless the home URL and the site URL differ. 2 2 3 Having arbitrary scopes makes it harder to unregister service workers that go away, such as via plugin deactivation . See https://github.com/xwp/pwa-wp/issues/26#issuecomment-4032682673 Having arbitrary scopes makes it harder to unregister service workers that go away, such as via plugin deactivation (as pointed out by @nico_martin). See https://github.com/xwp/pwa-wp/issues/26 4 4 5 5 Do we even really need a separate scope for admin vs frontend or should there just be one scope for the root of a site?