WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #36998, comment 2


Ignore:
Timestamp:
06/02/2016 11:38:16 AM (3 years ago)
Author:
dd32
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #36998, comment 2

    initial v1  
    33Realistically though, encoding spaces, multibyte characters, and other url components as long as it doesn't affect the security of the url being checked, is a sane thing to do. And it appears that we already urlencode multibyte characters.
    44
    5 Also, technically speaking, In the linked example that @ocean90 gave, the initial URL format is invalid, as it's not properly URL encoded (the entire `redirect_url` parameter should be encoded, so `%20` would've became `%2520` and the change wouldn't have been needed in the first place.
     5Also, technically speaking, In the linked example that @ocean90 gave, the initial URL format is invalid, as it's not properly URL encoded (the entire `redirect_url` parameter should be encoded, so `%20` would've became `%2520` and the change wouldn't have been needed in the first place).