WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #3699


Ignore:
Timestamp:
01/28/2007 12:21:47 AM (19 years ago)
Author:
markjaquith
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3699 – Description

    initial v1  
    33I installed Jerome's Keywords and experienced the behavior.  The problem is this:
    44
    5 1. Jerome's Keywords always assumes that it was able to successfully insert its field into the edit form.
    6 2. If the edit_post hook is called in a circumstance where the plugin was NOT able to insert its field into the edit form, it assumes that the user wanted to delete all keywords.  Thus, the plugin deletes all the keywords.
    7 3. Commenting in 2.1 calls wp_update_comment_count(), which runs the edit_post hook.
     5 1. Jerome's Keywords always assumes that it was able to successfully insert its field into the edit form.
     6 1. If the edit_post hook is called in a circumstance where the plugin was NOT able to insert its field into the edit form, it assumes that the user wanted to delete all keywords.  Thus, the plugin deletes all the keywords.
     7 1. Commenting in 2.1 calls wp_update_comment_count(), which runs the edit_post hook.
    88
    99While plugin authors are definitely to blame for assuming that "doesn't exist" is the same as "exists and is empty," we might want to consider using an alternative hook for announcing that the comment count has been updated for a post.