WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#37016 closed defect (bug) (fixed)

Minor Fixes: Text color for "Delete" button on widget should be Red

Reported by: monikarao Owned by: afercia
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Widgets Keywords: has-patch has-ui-feedback color-contrast
Focuses: ui, accessibility Cc:
PR Number:

Description

Text color on all "Delete" links are displayed in red color.
Example-
1."Delete Menu" link for Menus
2."Trash" link for Pages/Post
3."Delete" link for Users

It should display same red text color on "Delete" link for widget.

Attachments (12)

Delete menu.png (27.3 KB) - added by monikarao 3 years ago.
Delete Menu link for "Menus"
Trash button.png (7.5 KB) - added by monikarao 3 years ago.
Trash link for "Post"
delete-widget.png (13.8 KB) - added by monikarao 3 years ago.
Delete link on "widget"
delete-widget-example.png (12.8 KB) - added by lukecavanagh 3 years ago.
Delete widget example
before patch.png (18.2 KB) - added by patilswapnilv 3 years ago.
The earlier Delete button on Widgets
after patch.png (18.6 KB) - added by patilswapnilv 3 years ago.
The Delete button color after applying the patch
patch-to-37016.diff (435.1 KB) - added by patilswapnilv 3 years ago.
patch for ticket #37016
patch-to-37016-revision.patch (726 bytes) - added by patilswapnilv 3 years ago.
Revised Patch to #37016
37016.diff (328 bytes) - added by ibachal 3 years ago.
Patch for #37016
Screen Shot 2016-08-18 at 1.29.06 AM.png (191.7 KB) - added by ibachal 3 years ago.
37016 After patch in admin Widgets
Screen Shot 2016-08-18 at 1.30.44 AM.png (64.8 KB) - added by ibachal 3 years ago.
37016 After patch in customizer Widgets
37016.2.diff (862 bytes) - added by afercia 3 years ago.

Download all attachments as: .zip

Change History (33)

@monikarao
3 years ago

Delete Menu link for "Menus"

@monikarao
3 years ago

Trash link for "Post"

@monikarao
3 years ago

Delete link on "widget"

#1 @ocean90
3 years ago

  • Component changed from General to Widgets
  • Focuses accessibility added
  • Version trunk deleted

Related: #35126, #31476

@lukecavanagh
3 years ago

Delete widget example

@patilswapnilv
3 years ago

The earlier Delete button on Widgets

@patilswapnilv
3 years ago

The Delete button color after applying the patch

@patilswapnilv
3 years ago

patch for ticket #37016

#2 @patilswapnilv
3 years ago

  • Keywords has-patch reporter-feedback added

Hey Guys,

I took a shot at this and made the changes as required. Please have the look at the screenshots and the patch attached.

Let me know if there are any changes required.

Also, please bare with me incase I have done something wrong, this is my first patch. Help me improve ;-P

#3 @westonruter
3 years ago

  • Keywords reporter-feedback removed

@patilswapnilv hi, thanks for the patch. It looks much larger than it should be however. There should only be one patched file in the patch, wp-admin/css/common-rtl.css. The wp-admin/css/common-rtl.min.css file will be generated automatically by the build process. Then there are several other files in the patch that seem unrelated to the change you're making.

#4 @patilswapnilv
3 years ago

Two files actually. wp-admin/css/common.css and wp-admin/css/common-rtl.css

I think, I made some mistake while making the patch. I will remake it and then upload. Sorry for that, and thanks for bringing it to notice.

@patilswapnilv
3 years ago

Revised Patch to #37016

#5 @westonruter
3 years ago

@patilswapnilv and also, FYI, the RTL files are also automatically generated from the LTR files.

This ticket was mentioned in Slack in #design by westonruter. View the logs.


3 years ago

This ticket was mentioned in Slack in #design by presskopp. View the logs.


3 years ago

#8 @patilswapnilv
3 years ago

@westonruter Ohh, sorry did not know that. Do I need to update the patch, with just the common.css file diff. ?

#9 @westonruter
3 years ago

  • Keywords ui-feedback added

@patilswapnilv no, no worries. Just something to keep in mind to make it easier for you in the future.

#10 @patilswapnilv
3 years ago

@westonruter Thanks a lot.

#11 @afercia
3 years ago

  • Keywords color-contrast added

Related: #35622 (on hover it changes to #f00).

#12 @afercia
3 years ago

  • Milestone changed from Awaiting Review to Future Release

#13 @afercia
3 years ago

There are other Delete/Remove links that would need some love, maybe worth reviewing them across all the admin screens? Couple examples:

remove menu item in nav-menus.php red and not underlined

https://cldup.com/N4Z0FJZIVk.png

remove widget in the Customizer: blue and not underlined

https://cldup.com/fDOCmkBJdr.png

@ibachal
3 years ago

Patch for #37016

@ibachal
3 years ago

37016 After patch in admin Widgets

@ibachal
3 years ago

37016 After patch in customizer Widgets

#14 @ibachal
3 years ago

Hey Folks,

I have attached a patch (37016.diff) with screenshots for the color of Delete / Remove links in admin Widgets and Customizer Widgets. Please review.

This is my first patch so, please let me know if there’s anything to be improved / changed.

Last edited 3 years ago by ibachal (previous) (diff)

#15 @ibachal
3 years ago

  • Keywords needs-testing added

#16 follow-up: @karmatosed
3 years ago

  • Keywords has-ui-feedback added; ui-feedback removed

I totally agree we should catch all the instances we have can in this ticket @afercia. I'm removing ui-feedback to has-ui-feedback as so long as this is a consistency patch we're all good there. Thanks for the first patch @ibachal and the great work everyone. A great catch @monikarao.

#17 in reply to: ↑ 16 @monikarao
3 years ago

Replying to karmatosed:

I totally agree we should catch all the instances we have can in this ticket @afercia. I'm removing ui-feedback to has-ui-feedback as so long as this is a consistency patch we're all good there. Thanks for the first patch @ibachal and the great work everyone. A great catch @monikarao.

Thanks @karmatosed

#18 @afercia
3 years ago

  • Milestone changed from Future Release to 4.7
  • Owner set to afercia
  • Status changed from new to assigned

Let's try to have more red in 4.7 :)

#19 @afercia
3 years ago

Thinking the "Remove" and "Cancel" links in nav-menus.php are a different case, they use a styling that is a bit uncommon in core and maybe should be discussed separately. It would be useful to have a separate ticket for them to better track changes and history. Going to open a separate ticket for the menus screen and I'd propose to use this ticket to fix only the widget ones. About the color contrast ratio, see #35622.

@afercia
3 years ago

#20 @afercia
3 years ago

  • Keywords needs-testing removed

Refreshed patch to take care of the underline and the :focus state.

#21 @afercia
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 38536:

Widgets: Make the Delete/Remove links red.

For consistency and accessibility, all the UI controls that perform destructive
actions should be red.

Props monikarao, lukecavanagh, patilswapnilv, ibachal.
See #35622.
Fixes #37016.

Note: See TracTickets for help on using tickets.