Minor Fixes: Text color for "Delete" button on widget should be Red

[monikarao]

Text color on all "Delete" links are displayed in red color.
Example-
1."Delete Menu" link for Menus
2."Trash" link for Pages/Post
3."Delete" link for Users

It should display same red text color on "Delete" link for widget.

[monikarao]

Delete Menu link for "Menus"

[monikarao]

Trash link for "Post"

[monikarao]

Delete link on "widget"

[ocean90]

Related: #35126, #31476

[lukecavanagh]

Delete widget example

[patilswapnilv]

The earlier Delete button on Widgets

[patilswapnilv]

The Delete button color after applying the patch

[patilswapnilv]

patch for ticket #37016

[patilswapnilv]

Hey Guys,

I took a shot at this and made the changes as required. Please have the look at the screenshots and the patch attached.

Let me know if there are any changes required.

Also, please bare with me incase I have done something wrong, this is my first patch. Help me improve ;-P

[westonruter]

@patilswapnilv hi, thanks for the patch. It looks much larger than it should be however. There should only be one patched file in the patch, wp-admin/css/common-rtl.css. The wp-admin/css/common-rtl.min.css file will be generated automatically by the build process. Then there are several other files in the patch that seem unrelated to the change you're making.

[patilswapnilv]

Two files actually. wp-admin/css/common.css and wp-admin/css/common-rtl.css

I think, I made some mistake while making the patch. I will remake it and then upload. Sorry for that, and thanks for bringing it to notice.

[patilswapnilv]

Revised Patch to #37016

[westonruter]

@patilswapnilv and also, FYI, the RTL files are also automatically generated from the LTR files.

[patilswapnilv]

@westonruter Ohh, sorry did not know that. Do I need to update the patch, with just the common.css file diff. ?

[westonruter]

@patilswapnilv no, no worries. Just something to keep in mind to make it easier for you in the future.

[patilswapnilv]

@westonruter Thanks a lot.

[afercia]

Related: #35622 (on hover it changes to #f00).

[afercia]

There are other Delete/Remove links that would need some love, maybe worth reviewing them across all the admin screens? Couple examples:

remove menu item in nav-menus.php red and not underlined

remove widget in the Customizer: blue and not underlined

[ibachal]

Patch for #37016

[ibachal]

37016 After patch in admin Widgets

[ibachal]

37016 After patch in customizer Widgets

[ibachal]

Hey Folks,

I have attached a patch with screenshots for the color of Delete / Remove links in admin Widgets and Customizer Widgets. Please review.

This is my first patch so, please let me know if there’s anything to be improved / changed.

[karmatosed]

I totally agree we should catch all the instances we have can in this ticket @afercia. I'm removing ui-feedback to has-ui-feedback as so long as this is a consistency patch we're all good there. Thanks for the first patch @ibachal and the great work everyone. A great catch @monikarao.

[monikarao]

Replying to karmatosed:

I totally agree we should catch all the instances we have can in this ticket @afercia. I'm removing ui-feedback to has-ui-feedback as so long as this is a consistency patch we're all good there. Thanks for the first patch @ibachal and the great work everyone. A great catch @monikarao.

Thanks @karmatosed

[afercia]

Let's try to have more red in 4.7 :)

[afercia]

Thinking the "Remove" and "Cancel" links in nav-menus.php are a different case, they use a styling that is a bit uncommon in core and maybe should be discussed separately. It would be useful to have a separate ticket for them to better track changes and history. Going to open a separate ticket for the menus screen and I'd propose to use this ticket to fix only the widget ones. About the color contrast ratio, see #35622.

[afercia]

Refreshed patch to take care of the underline and the :focus state.

[afercia]

In 38536:

Widgets: Make the Delete/Remove links red.

For consistency and accessibility, all the UI controls that perform destructive
actions should be red.

Props monikarao, lukecavanagh, patilswapnilv, ibachal.
See #35622.
Fixes #37016.