WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 7 months ago

#37018 closed defect (bug) (fixed)

Underline for "Move to Trash" in post editor is missing

Reported by: monikarao Owned by: afercia
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch color-contrast has-screenshots
Focuses: ui, accessibility Cc:

Description

All the "Delete" and "Trash" links in WP admin are in red color with default text-decoration - underline.
But, "Move to Trash" link in "Publish" metabox has text-decoration explicitly set to none. This is a minor inconsistency in terms of styling.
I am attaching a patch for this.

Attachments (2)

ticket#37018.patch (250 bytes) - added by monikarao 11 months ago.
Patch for styling fix.
move to trash.png (14.7 KB) - added by monikarao 11 months ago.
Fixed styling for "Move to Trash"

Download all attachments as: .zip

Change History (13)

@monikarao
11 months ago

Patch for styling fix.

@monikarao
11 months ago

Fixed styling for "Move to Trash"

#1 @ocean90
11 months ago

  • Focuses accessibility added
  • Keywords has-patch added
  • Version trunk deleted

Related: #35126, #31476

All the "Delete" and "Trash" links in WP admin are in red color with default text-decoration - underline.

@monikarao Can you point to some of these links please?

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


9 months ago

#4 @afercia
9 months ago

  • Keywords color-contrast added
  • Milestone changed from Awaiting Review to Future Release

Thanks @monikarao there's an ongoing discussion about links, started with color contrast and touched also the underline see for example #35622. Worth noting, from an accessibility point of view, not all links must be underlined. For example the ones that are clearly perceivable as UI controls or menu items thanks to the context, don't need to be underlined. It's more a consistency issue across the whole admin and hopefully will be addressed as part of the colors revision effort.

#5 @monikarao
9 months ago

Thanks @afercia

#6 @afercia
8 months ago

  • Keywords needs-refresh added
  • Milestone changed from Future Release to 4.7

Related: #37969 where there's some consensus about adding the underline. These two tickets should be coordinated, since both need to change the submitdelete CSS class.

#7 @afercia
8 months ago

  • Owner set to afercia
  • Status changed from new to assigned

#8 @afercia
7 months ago

  • Keywords has-screenshots added

Posting here the same screenshots used on #37969. Worth noting this change would apply to all the Publish meta boxes: posts, attachments, comments, old link manager (any other?).

https://cldup.com/PE7M8P40Lv.png

#9 @afercia
7 months ago

Just noticed when moving the Publish meta box below the post into the "normal sortables" there's a stray CSS rule that causes this on :hover:

https://cldup.com/nFKhdYbj83.png

#10 @afercia
7 months ago

  • Keywords needs-refresh removed

#11 @afercia
7 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 38616:

Accessibility: Standardize the remove/delete/cancel links in the Menus screen and Publish meta boxes.

The submitdelete CSS class is used in various places across the admin for some
"red" action links. It is worth simplifying this rule for further improvements
related to color contrast.

  • simplifies a non-standard styling for the "Remove/Cancel" links in the Menus screen
  • underlines all the "Move to trash/Delete" red links in all the Publish meta boxes
  • fixes CSS classes usage for all the Publish meta boxes primary buttons
  • fixes broken layout for the old Link Manager publish meta box

Props karmatosed, hugobaeta, monikarao, afercia.
Fixes #37969, #37018. See #37448, #37138, #27314.

Note: See TracTickets for help on using tickets.