Underline for "Move to Trash" in post editor is missing

[monikarao]

All the "Delete" and "Trash" links in WP admin are in red color with default text-decoration - underline.
But, "Move to Trash" link in "Publish" metabox has text-decoration explicitly set to none. This is a minor inconsistency in terms of styling.
I am attaching a patch for this.

[monikarao]

Patch for styling fix.

[monikarao]

Fixed styling for "Move to Trash"

[ocean90]

Related: #35126, #31476

All the "Delete" and "Trash" links in WP admin are in red color with default text-decoration - underline.

@monikarao Can you point to some of these links please?

[monikarao]

@ocean90

Please see attached screenshot -> ​http://www.awesomescreenshot.com/image/1330759/fc82b5d5c1f3ceddf1801fab17af6884

[afercia]

Thanks @monikarao there's an ongoing discussion about links, started with color contrast and touched also the underline see for example #35622. Worth noting, from an accessibility point of view, not all links must be underlined. For example the ones that are clearly perceivable as UI controls or menu items thanks to the context, don't need to be underlined. It's more a consistency issue across the whole admin and hopefully will be addressed as part of the colors revision effort.

[monikarao]

Thanks @afercia

[afercia]

Related: #37969 where there's some consensus about adding the underline. These two tickets should be coordinated, since both need to change the submitdelete CSS class.

[afercia]

Posting here the same screenshots used on #37969. Worth noting this change would apply to all the Publish meta boxes: posts, attachments, comments, old link manager (any other?).

[afercia]

Just noticed when moving the Publish meta box below the post into the "normal sortables" there's a stray CSS rule that causes this on :hover:

[afercia]

In 38616:

Accessibility: Standardize the remove/delete/cancel links in the Menus screen and Publish meta boxes.

The submitdelete CSS class is used in various places across the admin for some
"red" action links. It is worth simplifying this rule for further improvements
related to color contrast.

• simplifies a non-standard styling for the "Remove/Cancel" links in the Menus screen
• underlines all the "Move to trash/Delete" red links in all the Publish meta boxes
• fixes CSS classes usage for all the Publish meta boxes primary buttons
• fixes broken layout for the old Link Manager publish meta box

Props karmatosed, hugobaeta, monikarao, afercia.
Fixes #37969, #37018. See #37448, #37138, #27314.